JoBoEVD/UglifyJS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix corner case with top-level singular reference

Browse Source
This commit is contained in:
alexlamsl 2017-05-02 23:55:36 +08:00
parent 6c40202625
commit 475f551f2f
2 changed files with 21 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/compress.js
View File

@ -711,7 +711,8 @@ merge(Compressor.prototype, {
return make_node(AST_UnaryPrefix, candidate, candidate); return make_node(AST_UnaryPrefix, candidate, candidate);
} }
if (candidate instanceof AST_VarDef) { if (candidate instanceof AST_VarDef) {
if (candidate.name.definition().references.length == 1) { var def = candidate.name.definition();
if (def.references.length == 1 && (!def.global || compressor.toplevel(def))) {
return maintain_this_binding(parent, node, candidate.value); return maintain_this_binding(parent, node, candidate.value);
} }
return make_node(AST_Assign, candidate, { return make_node(AST_Assign, candidate, {
@ -779,9 +780,7 @@ merge(Compressor.prototype, {
expr.expressions.forEach(extract_candidates); expr.expressions.forEach(extract_candidates);
} else if (expr instanceof AST_Definitions) { } else if (expr instanceof AST_Definitions) {
expr.definitions.forEach(function(var_def) { expr.definitions.forEach(function(var_def) {
if (var_def.value) { if (var_def.value) candidates.push(var_def);
candidates.push(var_def);
}
}); });
} else if (expr instanceof AST_SimpleStatement) { } else if (expr instanceof AST_SimpleStatement) {
extract_candidates(expr.body); extract_candidates(expr.body);

18
test/compress/collapse_vars.js
View File

@ -2059,3 +2059,21 @@ double_def: {
(a = a && y)(); (a = a && y)();
} }
} }
toplevel_single_reference: {
options = {
collapse_vars: true,
}
input: {
var a;
for (var b in x) {
var a = b;
b(a);
}
}
expect: {
var a;
for (var b in x)
b(a = b);
}
}