From 64d0d646462e7f7117cac5e361e9dfe9268b3c36 Mon Sep 17 00:00:00 2001 From: alexlamsl Date: Sat, 12 Dec 2020 00:01:15 +0800 Subject: [PATCH] fix corner case in `spread` fixes #4363 --- lib/compress.js | 4 +++- test/compress/spread.js | 23 +++++++++++++++++++++++ 2 files changed, 26 insertions(+), 1 deletion(-) diff --git a/lib/compress.js b/lib/compress.js index 1862fd10..27b080bb 100644 --- a/lib/compress.js +++ b/lib/compress.js @@ -10051,7 +10051,9 @@ merge(Compressor.prototype, { found = true; var exp = prop.expression; if (compressor.option("spread") && exp instanceof AST_Object && all(exp.properties, function(prop) { - return !(prop instanceof AST_ObjectGetter || prop instanceof AST_Spread); + return !(prop instanceof AST_ObjectGetter + || prop instanceof AST_ObjectSetter && prop.key instanceof AST_Node + || prop instanceof AST_Spread); })) { changed = true; exp.properties.forEach(function(prop) { diff --git a/test/compress/spread.js b/test/compress/spread.js index 8af7bffb..78348758 100644 --- a/test/compress/spread.js +++ b/test/compress/spread.js @@ -758,3 +758,26 @@ issue_4361: { ] node_version: ">=8" } + +issue_4363: { + options = { + objects: true, + spread: true, + } + input: { + ({ + ...{ + set [console.log("PASS")](v) {}, + }, + }); + } + expect: { + ({ + ...{ + set [console.log("PASS")](v) {}, + }, + }); + } + expect_stdout: "PASS" + node_version: ">=8" +}