diff --git a/lib/compress.js b/lib/compress.js index 454c1666..e135acaf 100644 --- a/lib/compress.js +++ b/lib/compress.js @@ -150,7 +150,9 @@ merge(Compressor.prototype, { } var passes = +this.options.passes || 1; var last_count = 1 / 0; + var mangle = { ie8: this.option("ie8") }; for (var pass = 0; pass < passes; pass++) { + node.figure_out_scope(mangle); if (pass > 0 || this.option("reduce_vars")) node.reset_opt_flags(this); node = node.transform(this); diff --git a/lib/minify.js b/lib/minify.js index 773e953a..f9d726bf 100644 --- a/lib/minify.js +++ b/lib/minify.js @@ -137,11 +137,9 @@ function minify(files, options) { if (options.wrap) { toplevel = toplevel.wrap_commonjs(options.wrap); } - if (timings) timings.scope1 = Date.now(); - if (options.compress) toplevel.figure_out_scope(options.mangle); if (timings) timings.compress = Date.now(); if (options.compress) toplevel = new Compressor(options.compress).compress(toplevel); - if (timings) timings.scope2 = Date.now(); + if (timings) timings.scope = Date.now(); if (options.mangle) toplevel.figure_out_scope(options.mangle); if (timings) timings.mangle = Date.now(); if (options.mangle) { @@ -199,9 +197,9 @@ function minify(files, options) { if (timings) { timings.end = Date.now(); result.timings = { - parse: 1e-3 * (timings.scope1 - timings.parse), - scope: 1e-3 * (timings.compress - timings.scope1 + timings.mangle - timings.scope2), - compress: 1e-3 * (timings.scope2 - timings.compress), + parse: 1e-3 * (timings.compress - timings.parse), + compress: 1e-3 * (timings.scope - timings.compress), + scope: 1e-3 * (timings.mangle - timings.scope), mangle: 1e-3 * (timings.properties - timings.mangle), properties: 1e-3 * (timings.output - timings.properties), output: 1e-3 * (timings.end - timings.output), diff --git a/test/compress/functions.js b/test/compress/functions.js index febf81c1..3c2ccce3 100644 --- a/test/compress/functions.js +++ b/test/compress/functions.js @@ -508,3 +508,41 @@ issue_2114_2: { } expect_stdout: "2" } + +issue_2428: { + options = { + collapse_vars: true, + inline: true, + passes: 2, + pure_getters: "strict", + reduce_vars: true, + side_effects: true, + toplevel: true, + unsafe: true, + unused: true, + } + input: { + function bar(k) { + console.log(k); + } + function foo(x) { + return bar(x); + } + function baz(a) { + foo(a); + } + baz(42); + baz("PASS"); + } + expect: { + function baz(a) { + console.log(a); + } + baz(42); + baz("PASS"); + } + expect_stdout: [ + "42", + "PASS", + ] +}