JoBoEVD/UglifyJS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix delete syntax checking under "use strict"

Browse Source
This commit is contained in:
alexlamsl 2017-04-23 04:18:03 +08:00
parent 379365d391
commit a60171c00b
3 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/parse.js
View File

@ -1470,7 +1470,7 @@ function parse($TEXT, options) {
croak("Invalid use of " + op + " operator", token.line, token.col, token.pos); croak("Invalid use of " + op + " operator", token.line, token.col, token.pos);
break; break;
case "delete": case "delete":
if (!(expr instanceof AST_PropAccess) && S.input.has_directive("use strict")) if (expr instanceof AST_SymbolRef && S.input.has_directive("use strict"))
croak("Calling delete on expression not allowed in strict mode", expr.start.line, expr.start.col, expr.start.pos); croak("Calling delete on expression not allowed in strict mode", expr.start.line, expr.start.col, expr.start.pos);
break; break;
} }

6
test/input/invalid/delete.js
View File

@ -1,8 +1,14 @@
function f(x) { function f(x) {
delete 42;
delete (0, x);
delete null;
delete x; delete x;
} }
function g(x) { function g(x) {
"use strict"; "use strict";
delete 42;
delete (0, x);
delete null;
delete x; delete x;
} }

2
test/mocha/cli.js
View File

@ -401,7 +401,7 @@ describe("bin/uglifyjs", function () {
assert.ok(err); assert.ok(err);
assert.strictEqual(stdout, ""); assert.strictEqual(stdout, "");
assert.strictEqual(stderr.split(/\n/).slice(0, 4).join("\n"), [ assert.strictEqual(stderr.split(/\n/).slice(0, 4).join("\n"), [
"Parse error at test/input/invalid/delete.js:7,11", "Parse error at test/input/invalid/delete.js:13,11",
" delete x;", " delete x;",
" ^", " ^",
"ERROR: Calling delete on expression not allowed in strict mode" "ERROR: Calling delete on expression not allowed in strict mode"