JoBoEVD/UglifyJS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix corner case in collapse_vars (#4866)

Browse Source 
fixes #4865
This commit is contained in:
Alex Lam S.L 2021-04-24 13:04:31 +01:00 committed by GitHub
parent 10dd9d4eaf
commit c296a63fb3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 21 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/compress.js
View File

@ -2560,7 +2560,7 @@ merge(Compressor.prototype, {
if (def.undeclared) return; if (def.undeclared) return;
if (is_arguments(def)) return; if (is_arguments(def)) return;
if (value !== rhs) { if (value !== rhs) {
if (value.is_immutable()) return; if (is_lhs_read_only(value, compressor)) return;
var referenced = def.references.length - def.replaced; var referenced = def.references.length - def.replaced;
if (referenced < 2) return; if (referenced < 2) return;
candidate = candidate.clone(); candidate = candidate.clone();
@ -7330,8 +7330,9 @@ merge(Compressor.prototype, {
def(AST_Assign, function(compressor) { def(AST_Assign, function(compressor) {
var left = this.left; var left = this.left;
if (left instanceof AST_PropAccess) { if (left instanceof AST_PropAccess) {
if (left.expression.may_throw_on_access(compressor, true)) return this; var expr = left.expression;
if (compressor.has_directive("use strict") && left.expression.is_constant()) return this; if (expr.may_throw_on_access(compressor, true)) return this;
if (compressor.has_directive("use strict") && expr.is_constant()) return this;
} }
if (left.has_side_effects(compressor)) return this; if (left.has_side_effects(compressor)) return this;
var right = this.right; var right = this.right;

17
test/compress/collapse_vars.js
View File

@ -8993,3 +8993,20 @@ issue_4852: {
} }
expect_stdout: "PASS" expect_stdout: "PASS"
} }
issue_4865: {
options = {
collapse_vars: true,
}
input: {
var NaN;
var a = NaN = "PASS";
console.log(a, NaN);
}
expect: {
var NaN;
var a = NaN = "PASS";
console.log(a, NaN);
}
expect_stdout: true
}