From e82cfbf296e35dbd9735a75abcd231e8bd94cd57 Mon Sep 17 00:00:00 2001 From: kzc Date: Thu, 28 Jan 2016 09:57:37 -0500 Subject: [PATCH] collapse_vars: cleaned up repeat var tests --- test/compress/collapse_vars.js | 56 +++++++++++++--------------------- 1 file changed, 21 insertions(+), 35 deletions(-) diff --git a/test/compress/collapse_vars.js b/test/compress/collapse_vars.js index 4c1ebdd7..39fee597 100644 --- a/test/compress/collapse_vars.js +++ b/test/compress/collapse_vars.js @@ -685,19 +685,35 @@ collapse_vars_repeated: { var dummy = 3, a = 5, unused = 2, a = 1, a = 3; return -a; } - function f2() { - var a = 3, a = a + 2; + function f2(x) { + var a = 3, a = x; return a; } + (function(x){ + var a = "GOOD" + x, e = "BAD", k = "!", e = a; + console.log(e + k); + })("!"), + + (function(x){ + var a = "GOOD" + x, e = "BAD" + x, k = "!", e = a; + console.log(e + k); + })("!"); } expect: { function f1() { return -3 } - function f2() { - var a = 3, a = a + 2; - return a + function f2(x) { + return x } + (function(x){ + var a = "GOOD" + x, e = "BAD", e = a; + console.log(e + "!"); + })("!"), + (function(x){ + var a = "GOOD" + x, e = "BAD" + x, e = a; + console.log(e + "!"); + })("!"); } } @@ -1087,33 +1103,3 @@ collapse_vars_short_circuit: { } } -collapse_vars_repeat_of_same_var_name: { - options = { - collapse_vars:true, sequences:true, properties:true, dead_code:true, conditionals:true, - comparisons:true, evaluate:true, booleans:true, loops:true, unused:true, hoist_funs:true, - keep_fargs:true, if_return:true, join_vars:true, cascade:true, side_effects:true - } - input: { - (function(x){ - var a = "GOOD" + x, e = "BAD", k = "?", e = a; - console.log(e + k); - })("!"), - - (function(x){ - var a = "GOOD" + x, e = "BAD" + x, k = "?", e = a; - console.log(e + k); - })("!"); - } - expect: { - (function(x){ - var a = "GOOD" + x, e = "BAD", e = a; - console.log(e + "?"); - })("!"), - - (function(x){ - var a = "GOOD" + x, e = "BAD" + x, e = a; - console.log(e + "?"); - })("!"); - } -} -