JoBoEVD/UglifyJS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
1,355 Commits 3 Branches 341 Tags 23 MiB
2dcc552ce0
Commit Graph

462 Commits

Author SHA1 Message Date
kzc
3ac2421932 collapse_vars: do not replace a constant in loop condition or init (#1562) 2017-03-07 01:42:33 +08:00
Alex Lam S.L
067e5a5762 fixup for #1553 (#1555) 
- `++a` is the one that is foldable
- transform `a++` into `++a` for better optimisation
 2017-03-05 17:15:37 +08:00
Alex Lam S.L
35a849dc48 collapse assignment with adjacent subsequent usage (#1553) 
- consolidate `cascade` optimisations
- support ++/-- postfixes
- remove redundant optimisation identified in #1460

fixes #368
 2017-03-05 14:56:14 +08:00
Alex Lam S.L
b70591be1a handle variable declaration within catch blocks (#1546) 
accounts for IE8- scoping
 2017-03-05 13:13:44 +08:00
Alex Lam S.L
b33e7f88e6 improve unsafe on undefined (#1548) 
`unsafe` turns undefined keyword into a variable of the same name if found, but that interferes with other related optimisations.

Keep track of such transformations to ensure zero information loss in the process.
 2017-03-05 13:09:27 +08:00
Alex Lam S.L
1f0333e9f1 stay safe with constants in IE8- (#1547) 
- `undefined` etc. can be redefined at top-level for IE8-, so disable related optimisations
- fixed `--support-ie8` catch mangle bug
 2017-03-05 12:51:11 +08:00
Alex Lam S.L
78d1bb92d4 fix a corner case in #1530 (#1552) 2017-03-05 12:12:59 +08:00
kzc
ce54c9ccee disallow collapse_vars constant replacement in for-in statements (#1543) 2017-03-04 02:39:54 +08:00
Alex Lam S.L
07accd2fbb process code with implicit return statement (#1522) 
Bookmarklet for instance implicitedly assumes a "completion value" without using `return`.
The `expression` option now supports such use cases.
Optimisations on IIFEs also enhanced.

fixes #354
fixes #543
fixes #625
fixes #628
fixes #640
closes #1293
 2017-03-03 18:13:07 +08:00
Alex Lam S.L
18059cc94f compress numerical expressions (#1513) 
safe operations
- `a === b` => `a == b`
- `a + -b`  => `a - b`
- `-a + b`  => `b - a`
- `a+ +b`   => `+b+a`

associative operations
(bit-wise operations are safe, otherwise `unsafe_math`)
- `a + (b + c)`       => `(a + b) + c`
- `(n + 2) + 3`       => `5 + n`
- `(2 * n) * 3`       => `6 * n`
- `(a | 1) | (2 | d)` => `(3 | a) | b`

fixes #412
 2017-03-03 18:04:32 +08:00
Alex Lam S.L
b5e0e8c203 facilitate fix for #1531 (#1542) 2017-03-03 07:12:24 +08:00
Alex Lam S.L
17b81350d4 fix chained assignment with unused (#1540) 
When #1450 optimises `a=b=42`, it stops after the first variable even if both are unused.

fixes #1539
 2017-03-03 04:45:20 +08:00
kzc
4d63d4f5b3 collapse_vars should not replace constant in for-in init section (#1538) 
fixes #1537
 2017-03-03 03:51:15 +08:00
Alex Lam S.L
70d72ad806 properly cover all cases of for-in loop variables (#1536) 2017-03-03 02:39:57 +08:00
Alex Lam S.L
fe9227a41b fix reference marking in for-in loops (#1535) 
fixes #1533
 2017-03-03 00:56:06 +08:00
Alex Lam S.L
b49e142a26 disable do{...}while(false) optimisation (#1534) 
- fails to handle `break` in body

fixes #1532
 2017-03-03 00:54:41 +08:00
kzc
ee3b39b909 optimize trivial IIFEs returning constants (#1530) 2017-03-02 15:11:40 +08:00
Alex Lam S.L
9699ffb1af trim unused invocation parameters (#1526) 2017-03-02 11:33:59 +08:00
Alex Lam S.L
fdc9b9413b minor improvement to string optimisation (#1514) 
- "" + "a"     => "a"
- "" + a + "b" => a + "b"
- "a" + ""     => "a" (improving on #45)
 2017-03-02 11:31:39 +08:00
Alex Lam S.L
7aa69117e1 fix corner cases in reduce_vars (#1524) 
Avoid variable substitution in the following cases:
- use of variable before declaration
- declaration within conditional code blocks
- declaration within loop body

fixes #1518
fixes #1525
 2017-03-02 00:20:53 +08:00
Alex Lam S.L
c2334baa48 fix crash on missing props to string_template() (#1523) 
Patched up `make_node()` without `orig`.

There may be other cases where `start` could be missing, so make it print "undefined" instead of crashing.

fixes #1518
 2017-03-01 15:25:26 +08:00
Alex Lam S.L
f5cbe19b75 invert reduce_vars tracking flag (#1519) 
Modules like webpack and grunt-contrib-uglify still uses `ast.transform(compressor)` before `Compressor.compress(ast)` was introduced.

Workaround this compatibility issue by deactivating `reduce_vars` in such case.

Also fix use case with omitted `options` when calling `Compressor()`.

fixes #1516
 2017-03-01 04:12:10 +08:00
Alex Lam S.L
b34fa11a13 fix evaluate on object getter & setter (#1515) 2017-03-01 02:03:47 +08:00
Alex Lam S.L
4365a51237 temporarily disables reduce_vars (#1517) 
... as we investigate #1516
 2017-03-01 00:25:43 +08:00
Alex Lam S.L
858e6c78a4 warn & drop #__PURE__ iff IIFE is dropped (#1511) 
- consolidate `side-effects` optimisations
- improve string `+` optimisation
- enhance literal & `conditionals` optimisations
 2017-02-28 02:25:44 +08:00
Alex Lam S.L
13be50a4a9 faster tree transversal (#1462) 
- convert `[].forEach()` to for-loops
 2017-02-26 05:58:26 +08:00
Alex Lam S.L
16cd5d57a5 consolidate evaluate & reduce_vars (#1505) 
- improve marking efficiency
- apply smarter `const` replacement to `var`

fixes #1501
 2017-02-26 00:40:33 +08:00
alexlamsl
4e49302916 enable collapse_vars & reduce_vars by default 
- fix corner cases in `const` optimisation
- deprecate `/*@const*/`

fixes #1497
closes #1498
 2017-02-24 01:46:57 +08:00
kzc
1e51586996 Support marking a call as pure 
A function call or IIFE with an immediately preceding comment
containing `@__PURE__` or `#__PURE__` is deemed to be a
side-effect-free pure function call and can potentially be
dropped.

Depends on `side_effects` option.

`[#@]__PURE__` hint will be removed from comment when pure
call is dropped.

fixes #1261
closes #1448
 2017-02-21 14:24:18 +08:00
alexlamsl
26fbeece1c fix pure_funcs & improve side_effects 
- only drops side-effect-free arguments
- drop side-effect-free parts with discarded value from `AST_Seq` & `AST_SimpleStatement`

closes #1494
 2017-02-21 13:31:59 +08:00
alexlamsl
ec64acd2c8 introduce unsafe_proto 
- `Array.prototype.slice` => `[].slice`

closes #1491
 2017-02-21 13:29:58 +08:00
alexlamsl
e275148998 enhance global_defs 
- support arrays, objects & AST_Node
- support `"a.b":1` on both cli & API
- emit warning if variable is modified
- override top-level variables

fixes #1416
closes #1198
closes #1469
 2017-02-21 13:29:58 +08:00
alexlamsl
974247c8c0 evaluate AST_SymbolRef as parameter 
fix invalid boolean conversion now exposed in `make_node_from_constant()`

closes #1477
 2017-02-21 13:29:58 +08:00
alexlamsl
a0f4fd390a improve reduce_vars and fix a bug 
- update modified flag between compress() passes
- support IIFE arguments
- fix corner case with multiple definitions

closes #1473
 2017-02-21 13:29:58 +08:00
alexlamsl
b8b133d91a improve keep_fargs & keep_fnames 
- utilise in_use_ids instead of unreferenced()
- drop_unused now up-to-date for subsequent passes

closes #1476
 2017-02-21 13:29:58 +08:00
kzc
6ffbecb72b smarter const replacement taking name length into account 
closes #1459
 2017-02-21 13:29:58 +08:00
alexlamsl
f0ff6189be clean up negate_iife 
- remove extra tree scanning phase for `negate_iife`
- `negate_iife` now only deals with the narrowest form, i.e. IIFE sitting directly under `AST_SimpleStatement`
- `booleans`, `conditionals` etc. will now take care the rest via more accurate accounting
- `a(); void b();` => `a(); b();`

fixes #1288
closes #1451
 2017-02-21 13:29:58 +08:00
alexlamsl
6b3c49e458 improve string concatenation 
shuffle associative operations to minimise parentheses and aid other uglification efforts

closes #1454
 2017-02-21 13:29:57 +08:00
alexlamsl
f584ca8d07 -c sequences=N suboptimal at N expression cutoff 
N = 2:
  a;
  b;
  c;
  d;
was:
  a, b;
  c;
  d;
now:
  a, b;
  c, d;

fixes #1455
closes #1457
 2017-02-21 13:29:57 +08:00
alexlamsl
ae4db00991 tweak do-while loops 
- `do{...}while(false)` => `{...}`
- clean up `AST_While` logic

closes #1452
 2017-02-21 13:29:57 +08:00
alexlamsl
100307ab31 fixes & improvements to [].join() 
fixes
- [a].join() => "" + a
- ["a", , "b"].join() => "a,,b"
- ["a", null, "b"].join() => "a,,b"
- ["a", undefined, "b"].join() => "a,,b"

improvements
- ["a", "b"].join(null) => "anullb"
- ["a", "b"].join(undefined) => "a,b"
- [a + "b", c].join("") => a + "b" + c

closes #1453
 2017-02-21 13:29:57 +08:00
alexlamsl
148047fbbf drop unused: toplevel, assign-only 
- assign statement does not count towards variable usage by default
- only works with assignments on the same scope level as declaration
- can be disabled with `unused` set to "keep_assign"
- `toplevel` to drop unused top-level variables and/or functions
- `top_retain` to whitelist top-level exceptions

closes #1450
 2017-02-21 13:29:57 +08:00
kzc
d11dca3cf9 fix stray else in compress with conditionals=false 
closes #1449
 2017-02-21 13:29:57 +08:00
alexlamsl
e5badb9541 enable typeof "undefined" for general use 
move out of unsafe, guard corner case with screw_id8 instead

closes #1446
 2017-02-18 19:01:42 +08:00
alexlamsl
11676f9d72 fix crash in unsafe replacement of undefined 
remove extraneous call to AST_SymbolRef.reference()

closes #1443
 2017-02-18 18:58:23 +08:00
Anthony Van de Gejuchte
dd31d12a91 Improve optimizing function() { if(c){return foo} bar();} 
closes #1437
 2017-02-18 18:56:18 +08:00
Alex Lam S.L
0610c020b1 optimise binary operands with evaluate() (#1427) 
- remove call to evaluate() in is_constant() and let nested optimize() does its job instead
- reject RegExp in is_constant() and remove special case logic under collapse_vars
- operands to conditionals optimisation are now always evaluate()-ed
- throw error in constant_value() instead of returning undefined to catch possible bugs, similar to make_node_from_constant()
- optimise binary boolean operators under `evaluate` instead of `conditionals`
 2017-01-26 12:16:50 +01:00
Alex Lam S.L
0d7d4918eb augment evaluate to extract within objects (#1425) 
- gated by `unsafe`
- replaces previous optimisation specific to String.length
- "123"[0] => 1
- [1, 2, 3][0] => 1
- [1, 2, 3].length => 3
- does not apply to objects with overridden prototype functions
 2017-01-26 12:14:18 +01:00
alexlamsl
48284844a4 add missing LHS cases which global_defs should avoid 2017-01-19 21:06:28 +01:00
Anthony Van de Gejuchte
79b98a9fe8 Do not overwrite options.comments + cleanup 2016-11-29 20:24:08 +01:00
kzc
fc9804b909 Fix (typeof side_effect()) in boolean context 
Fixes #1289 with suggestion by @rvanvelzen
 2016-10-06 13:50:11 +02:00
alexlamsl
4761d07e0b Optimize unmodified variables 2016-10-01 11:36:11 +02:00
kzc
25fc02743a Account for side effects in string + expr optimization 2016-09-01 09:24:56 -04:00
kzc
0bd8053524 implement optimization: (x = 2 * x) ---> (x *= 2) 2016-08-30 08:43:02 -04:00
Richard van Velzen
8430123e9d Fix negate_iife transform to return a correct tree for nested IIFEs 
Fix for #1256, partially reverts d854523783
 2016-08-17 11:55:59 +02:00
Anthony Van de Gejuchte
7eb52d2837 Keep const in own scope while compressing 
- Fixes #1205
- Fix provided by @kzc
 2016-07-15 13:20:52 +02:00
kzc
b40d5de69c Change the default sequences limit to 200 to speed up compress. 
Has little or no impact on minification size in the majority of
cases but can speed up rollup builds significantly.

This sequences change also has the beneficial side effect of avoiding
"stack size exceeded" errors on very large input files.

The user is free to alter the sequences limit if they are so inclined.
The previous sequences limit was 2000. 20 is often sufficient.
 2016-07-01 09:41:31 +02:00
kzc
b7ef7840f3 Allow sequences maximum length to be user configurable. 2016-07-01 09:41:31 +02:00
kzc
02c638209e Enable --screw-ie8 by default. 
catch identifier is mangled correctly for ES5 standards-compliant JS engines by default.

Unconditionally use the ie8 if/do-while workaround whether or not --screw-ie8 is enabled.

To support non-standard ie8 javascript use: uglifyjs --support-ie8
 2016-06-30 21:49:48 +02:00
kzc
335b72df03 Fix spidermonkey AST (ESTree) export and import, Array holes 
Fixes: #1156 #1161

Also add test to exercise Uglify after spidermonkey export/import of itself.
 2016-06-30 21:44:12 +02:00
kzc
ace8aaa0f4 Fix conditional expressions of form (x ? -1 : -1) 
Fixes #1154, #1153
 2016-06-21 14:52:13 -04:00
kzc
0c003c92a8 Don't replace undefined, NaN and Infinity within with scope 2016-06-21 10:53:29 +02:00
Anthony Van de Gejuchte
d7971ba0e4 Fix test262 failures related to <, <=, in and instanceof 
Fixed-by: @kzc
 2016-06-15 23:11:08 +02:00
Anthony Van de Gejuchte
ea31da2455 Don't drop unused if scope uses with statement 
Fix provided by @kzc
 2016-06-12 14:30:28 +02:00
kzc
09d5707a8a collapse_vars: Do not consider RegExp literals to be constants 
Fixes #1100
 2016-05-27 00:03:51 -04:00
kzc
1e390269d4 Optimize if_return for single if/return cases. 
Fixes #1089
 2016-05-24 17:54:08 +02:00
Richard van Velzen
bc49dfd27a Completely allow evaluating -0 2016-05-24 17:50:29 +02:00
Richard van Velzen
27eedbc302 Never produce -0 when evaluating expressions (like -"") 
Fix for #1085. The major case was already there, but more expressions can result in -0.
 2016-05-17 22:34:38 +02:00
kzc
5f464b41e2 Simplify iife new fix 
as suggested by @rvanvelzen.

Added a test for IIFEs in nested contexts.
 2016-05-15 19:12:17 -04:00
kzc
bcc1318d4b Do not apply negate_iife optimization to new expression 2016-05-09 03:19:28 -04:00
Richard van Velzen
4fe630431c Hoist functions when reversing if (x) return; ... vs. if (!x) ... 
Fixes #1052
 2016-04-23 23:48:33 +02:00
kzc
c55dd5ed74 Add passes compress option. Fix duplicate compress warnings. 2016-04-19 20:05:33 +02:00
Richard van Velzen
4b4528ee05 Prevent endless recursion when evaluating self-referencing consts 
Fix #1041
 2016-04-13 15:03:31 +02:00
Mihai Bazon
b5a7a231f7 Actually limit sequence length. 
Fix #1038
 2016-04-12 14:17:24 +03:00
kzc
3907a5e3b2 Fix warnings for referenced non-hoisted functions. 
Fixes #1034

Also added `expect_warnings` functionality to test framework.
 2016-04-11 18:15:20 +02:00
Mihai Bazon
9317237372 Avoid using inherited hasOwnProperty 
Fix #1031
 2016-04-07 13:16:22 +03:00
kzc
98434258d0 Optimize ternaries with boolean consequent or alternative. 
Fixes #511
 2016-04-02 17:22:12 +02:00
kzc
45ddb9caeb Speedup unused compress option for already minified code 
Fixes: #321 #917 #1022
 2016-03-28 17:58:50 -04:00
kzc
11b0efdf84 boolean_expression ? true : false --> boolean_expression 2016-02-22 17:59:36 +01:00
kzc
5486b68850 Take operator || precendence into account for AST_If optimization. 
Fixes #979.
 2016-02-21 12:05:02 -05:00
alexlamsl
6547437725 preserve ThisBinding for side_effects 2016-02-17 19:34:01 +01:00
Richard van Velzen
9662228f6a Don't compress (0, eval)() to eval() 2016-02-16 19:00:48 +01:00
alexlamsl
31a9b05c96 Preserve ThisBinding in conditionals & collapse_vars 
Fixes #973
 2016-02-16 18:47:49 +01:00
kzc
7c3fee9e31 collapse_vars: avoid replacement across AST_Case nodes to be on safe side even though no issues seen. 2016-01-29 10:35:07 -05:00
kzc
929de2b0de collapse_vars: fix if/else and ternary operator side effects 2016-01-28 12:17:06 -05:00
kzc
af2472d85e collapse_vars: fix bug in repeated var defs of same name 2016-01-28 16:48:50 +01:00
kzc
0a38a688f9 fix bug in collapse_vars for right side of "||" and "&&" 2016-01-27 14:18:46 -05:00
kzc
f4c2ea37bf Collapse single use var definitions 
Fix #721
 2016-01-27 11:48:15 +02:00
Mihai Bazon
fe4e9f9d97 Fix hoisting the var in ForIn 
Close #913
 2016-01-05 13:56:52 +02:00
kzc
774bda13cd #873 Fix conditionals optimizations with default compress options 2015-11-24 13:27:50 -05:00
Mihai Bazon
7f48d5b33c Fix endless loop 
Close #866
 2015-11-16 12:08:24 +02:00
Mihai Bazon
b6968b6bd2 Limit max iterations for tighten_body 
Ref #866
 2015-11-16 12:08:24 +02:00
Mihai Bazon
7691bebea5 Rework has_directive 
It's now available during tree walking, i.e. walker.has_directive("use
asm"), rather than as part of the scope.  It's thus no longer necessary
to call `figure_out_scope` before codegen.  Added special bits in the
code generator to overcome the fact that it doesn't inherit from
TreeWalker.

Fix #861
 2015-11-11 22:15:25 +02:00
kzc
bd0ae6569f return undefined optimization no longer uses return_void_0 option 2015-10-29 08:19:12 +01:00
kzc
7491d07666 optimize return undefined and return void 0 2015-10-29 08:19:12 +01:00
kzc
593677d2ff Add proper support for "use asm"; blocks. Disable -c optimization within "use asm"; sections and preserve floating point literals in their original form. Non-asm.js sections are optimized as before. Asm.js sections can still be mangled and minified of whitespace. No special command line flags are required. 2015-10-07 10:00:28 +02:00
Ville Lautanala
5fd12451f9 Control keeping function arguments with a single option 2015-09-14 19:38:45 +02:00
Richard van Velzen
e3bd223dac Don't change sequences that influence lexical binding in calls 
Fixes #782
 2015-08-25 10:53:35 +02:00
Christopher Chedeau
3ff0b9e0c9 [Fix] --define replaces SymbolRefs in LHS of assignments 
See #208 for context
 2015-08-10 11:22:36 -07:00
thorn0
252fc65558 Advanced way to specify if a function call might have side effects. #400 2015-07-29 14:36:42 +02:00
Mihai Bazon
905b601178 Don't attempt to negate non-boolean AST_Binary 
Fix #751
 2015-07-22 16:55:55 +03:00
Mihai Bazon
63fb2d5a44 Merge pull request #735 from kzc/master 
optimizations for && and || where left side is constant expression
 2015-07-20 09:58:01 +03:00
Mihai Bazon
85a5fc0aeb Don't drop parens in a * (b * c). Close #744 2015-06-30 10:10:29 +03:00
kzc
f47b2b52a5 operator && and || optimization: add "else" before "if" as intended 2015-06-14 17:44:26 -04:00
kzc
fedb6191a1 optimizations for && and || where left side is constant expression 2015-06-11 23:22:38 -04:00
Mihai Bazon
a5b60217ce Fix compressing conditionals 
Only transform foo() ? EXP(x) : EXP(y) into EXP(foo() ? x : y) if EXP has no
side effects.

Fix #710
 2015-05-18 13:56:04 +03:00
Mihai Bazon
c3a10c135e Avoid spurious brackets when dropping unused vars 
Fix #702
 2015-05-04 14:49:17 +03:00
Mihai Bazon
274e1b3dc7 Drop NaN -> 0/0 transformation. 
Fix #687
 2015-04-17 11:26:36 +03:00
Mihai Bazon
18c63ff3d8 Fix compression of conditionals 
Don't move the condition on the right side of an assignment when
the left side may have side effects.

Fix #677
 2015-04-13 17:29:48 +03:00
Mihai Bazon
276b9a31cd Fix compressing ![foo()]; as a statement 
need to check whether the literal has any side effects before replacing that
with `false`.
 2015-03-23 23:27:00 +02:00
Mihai Bazon
5801fa39e9 [sequencesize] Actually even better: 
do create the sequence even if the stat list is bigger than 2000 statements,
but limit the sequence itself to 2000 expressions.

Ref #414
 2015-03-22 13:02:45 +02:00
Mihai Bazon
f0ab1b02e6 Avoid sequencesize for more than 2000 statements. 
It hardly saves any bytes for a sequence so long, and it risks blowing the
stack with the recursive Seq functions.

Ref #414
 2015-03-22 12:51:15 +02:00
Mihai Bazon
36c28e02fd Add start/end nodes for NaN/Infinity transformations 2015-03-22 12:50:36 +02:00
Mihai Bazon
ecfd881ac6 Keep unused function arguments by default 
Discarding unused function arguments affects function.length, which can lead
to some hard to debug issues.  This optimization is now done only in "unsafe
mode".

Fix #121
 2015-03-20 10:28:51 +02:00
Richard van Velzen
992b6b9fcc Fix invalid removal of left side in && and || compression 
See #637. This does not produce the optimal result, but it does prevent the removal of non-side-effect-free code.
 2015-02-11 21:08:41 +01:00
Richard van Velzen
605362f89d Drop all console statements properly 
Because the base reference can be an member expression as well, we have to dig a bit deeper to find the leftmost base reference.

Fixes #451
 2015-01-31 13:24:44 +01:00
Tal Ater
a1a4c2ada7 Optimize conditionals where the consequent and alternative are both booleans and not equivalent 2015-01-13 18:27:21 +01:00
Richard van Velzen
42ecd42ac0 Replace the correct node when replacing in void sequences 
Close #611.
 2015-01-12 17:09:34 +01:00
Mihai Bazon
a10f6a96d7 Merge pull request #482 from arty-name/inline-ng-inject 
added @ngInject support for inline functions
 2015-01-11 12:10:42 +02:00
Mihai Bazon
61c233a08e Fix make_node_from_constant for Regexp-s 
Close #588
 2015-01-07 11:20:04 +02:00
Mihai Bazon
d2d716483a aborts(AST_If) returns the if node 
Previously it returned the abort node from the alternative branch.  This is
not much use as it can be different from the one in the body
branch (i.e. return vs. throw) and can trick us into issues like #591.

Fix #591
 2015-01-06 14:01:35 +02:00
Mihai Bazon
e1f0747e4c Support keep_fnames in compressor, and --keep-fnames. #552 
Passing `--keep-fnames` will enable it both for compressor/mangler, so that
function names will not be dropped (when unused) nor mangled.
 2015-01-05 11:03:13 +02:00
Richard van Velzen
f4d36a58c2 Fix #569 
When no arguments are given to `new Function()`, it should be treated as
a regular anonymous function (http://es5.github.io/#x15.3.2.1)
 2015-01-04 13:37:59 +01:00
Richard van Velzen
c75f5a1fd8 Fix #597 
NaN and Infinity were replaced in the output generation, instead of
during compression. This could lead to results where `1/0` was inserted
without parens leading to invalid output.

The nodes are replaced in the compression step now, and the output
generation returns their regular names. This should not be a problem,
since they're already only constructed from the original name.
 2014-12-31 12:23:00 +01:00
Mihai Bazon
01d19b4b52 Referencing a global is assumed to have side effects. 
Close #550
 2014-09-28 11:18:25 +03:00
Tal Ater
fb0ec720a4 Compress conditions that have side effects using sequences 2014-09-04 02:57:49 +03:00
Tal Ater
885835a655 Compress conditional assignments where all possible outcomes are equivalant and condition has no side effects 2014-09-02 23:30:25 +03:00
Mihai Bazon
4c64554808 Turn foo.new into foo["new"] when not --screw-ie8. Fix #534 2014-08-26 10:11:01 +03:00
Mihai Bazon
548beeb6b1 Prevent error for Function(""). Close #538 2014-08-20 09:16:34 +03:00
Dan Wolff
8511e80f48 Evaluate "foo".length ==> 3 2014-07-01 11:06:51 +03:00
Artemy Tregubenko
524a8a42a4 added @ngInject support for inline functions 2014-05-11 14:01:08 +02:00
Mihai Bazon
ef2ef07cbd Add option keep_fargs. 
By default it's `false`.  Pass `true` if you need to keep unused function
arguments.

Close #188.
 2014-02-08 12:33:56 +02:00
Matt Basta
ac0086a745 Simplify nested conditionals if possible 2014-02-06 12:39:13 -08:00
Mihai Bazon
5344b7dab8 Fix if_return dropping the alternative. Close #413 2014-01-31 10:44:13 +02:00
Mihai Bazon
c3087dd179 Better process_for_angular before other statement reductions. #395 2014-01-08 11:39:24 +02:00
Mihai Bazon
2c305af478 Support @ngInject with angular compressor option. Close #395. 2014-01-08 11:28:32 +02:00
Mihai Bazon
2c88eb6fbe doh. 2014-01-07 12:54:14 +02:00
Mihai Bazon
27142df4f5 minor: exp["10"] => exp[10] 2014-01-07 12:48:21 +02:00
Mihai Bazon
b521b4b926 Conditional/call optimization 
foo ? bar(x) : bar(y)  ==>  bar(foo ? x : y)
 2013-12-29 10:31:30 +02:00
Mihai Bazon
5a083a938d Optimize seq,void 0. Close #377. 
(x, void 0)    => void x
    (x, undefined) => void x
 2013-12-22 11:36:45 +02:00
Mihai Bazon
dc5f70eab5 Add drop_console option to the compressor 2013-12-10 19:44:41 +02:00
Mihai Bazon
df8c5623af minor 2013-12-10 19:39:03 +02:00
Mihai Bazon
d2190c2bf3 Properly scope catch identifier when --screw-ie8 
Fix #344
 2013-11-28 16:43:30 +02:00
Mihai Bazon
50b8d7272c Fix faulty compression 
`String(x + 5)` is not always the same as `x + "5"`.  Overlooked that. :-(

Close #350
 2013-11-20 21:13:16 +02:00
Mihai Bazon
7d11b96f48 Only descend twice after drop_unused if it's the same node type. 
Fix #345
 2013-11-08 11:57:17 +02:00
Mihai Bazon
eab99a1c3d Better fix for #343 
We can in fact lift sequences, but only if the operation is assignment and
the left-hand side has no side effects nor property access -- that should
guarantee that whatever we place before it cannot affect the sense of the
assignment.

Dropped contrived test case (too hard to support it now), added a more
meaningful one.
 2013-11-06 10:48:48 +02:00
Mihai Bazon
f4919e3a25 Do not lift sequence from right-hand side of binary operation. Fix #343 2013-11-06 10:18:28 +02:00
Mihai Bazon
b70670b69f Fix regression after e4c5302406 
`x * (y * z)` ==> `x * y * z` -- the better place to do this is in the
compressor rather than codegen.
 2013-10-30 10:45:58 +02:00
Mihai Bazon
9dd97605bc indentation 2013-10-30 10:44:50 +02:00
Richard van Velzen
785c6064cc Disallow reversal where lhs has higher or equal precedence 
Fixes #267
 2013-10-29 21:37:36 +01:00
Richard van Velzen
e2daee9a65 Fix RHS concat (raised in #330) 
When attempting to concat the left-side of the rhs, make sure the rhs is
a string.
 2013-10-26 18:44:52 +02:00
Richard van Velzen
1a5a4bd631 Fix #269 
Shorten most primitives where possible. Also optimize some edge cases.
 2013-10-24 11:08:33 +02:00
Richard van Velzen
7055af8221 Fix #280 
The `init` of the `ForStatement` is not a `BlockStatement` before it was
descended. The descend has to happen first, and *then* the actual
checks.
 2013-10-23 22:26:04 +02:00
Mihai Bazon
63d04fff69 Revert #3a81f60 for now 
(with it some tests break and it can generate invalid output, see issue #44)
 2013-10-22 21:50:55 +03:00
Mihai Bazon
3fa9265ce4 wrap up 2013-10-09 22:15:43 +03:00
Mihai Bazon
3a81f60982 Don't drop_unused before compression. 
Fix #280, #282
 2013-10-09 19:15:09 +03:00
Mihai Bazon
f2348dd98b Rename clean_getters to pure_getters; add pure_funcs. 2013-10-04 13:17:25 +03:00
Mihai Bazon
8cc86fee60 add clean_getters compressor option (default false) 
allows one to specify if `foo.bar` is considered to have side effects.
 2013-10-02 19:38:01 +03:00
Mihai Bazon
88fb83aa81 minor optimization 
unlikely to help in hand-written code:

    (something() ? foo : bar) == foo  ==>  something()
 2013-10-02 15:31:31 +03:00
Mihai Bazon
95b4507c02 Fix error in the output minifying Function("return this")() 2013-09-30 11:49:29 +03:00
Mihai Bazon
afdaeba37d More attempts to determine when addition is associative 
Somebody hit me with bug reports on this. :)

Refs #300
 2013-09-22 15:26:10 +03:00
Mihai Bazon
037199bfe2 Actually let's move away those monsters from the evaluate function 
ev() should do a single thing — evaluate constant expressions.  if that's
not possible, just return the original node.  it's not the best place for
partial evaluation there, instead doing it in the compress functions.
 2013-09-22 15:00:42 +03:00
Mihai Bazon
583fac0a0f More dirty handling of [ ... ].join() in unsafe mode 
Close #300
 2013-09-22 13:14:42 +03:00
Dan Wolff
e8158279ff Evaluate [...].join() if possible: minor bugfix 
Follow-up to 78e98d2.
 2013-09-22 11:34:30 +03:00
Mihai Bazon
78e98d2611 When unsafe is set, evaluate [...].join() if possible 
Close #298
 2013-09-19 18:20:45 +03:00
Dan Wolff
8d14efe818 Concatenate strings also on the right-hand side of an expression that cannot be evaluated. Fix #126 
E.g. converts:
  a+'Hello'+'World'
to
  a+'HelloWorld'
 2013-09-19 13:03:03 +03:00
Mihai Bazon
85b527ba3d Disallow continue referring to a non-IterationStatement. Fix #287 
Simplifies handling of labels (their definition/references can be easily
figured out at parse time, no need to do it in `figure_out_scope`).
 2013-09-02 19:36:16 +03:00
Mihai Bazon
ed80b4a534 Move support for negate_iife in the compressor, rather than code generator 
(the code generator doesn't maintain enough context to know whether
the return value is important or discarded)

Fixes #272
 2013-08-20 17:45:52 +03:00
Michael Ficarra
d9ad3c7cbf fixes #259: don't unnecessarily quote object properties when --screw-ie8 2013-08-18 19:45:06 -05:00
Mihai Bazon
4c4dc2137c Don't drop unused setter argument. 
Fix #257
 2013-08-07 12:04:58 +03:00
Mihai Bazon
964d5b9aa4 Don't pretend to evaluate lambdas 
Fix #255
 2013-08-04 21:44:17 +03:00
Mihai Bazon
41c627379c Reverting "added option for dropping unused params" 
Revert "added option for dropping unused params"

(turns out we already had the `unused` option for this.)

This reverts commit e54df2226f.
 2013-07-25 18:08:36 +03:00
Dusan Bartos
e54df2226f added option for dropping unused params 2013-07-25 17:37:47 +03:00
Mihai Bazon
02a84385a0 Don't swap binary ops when "use asm" is in effect. 
Refs #167
 2013-06-07 12:52:09 +03:00
Mihai Bazon
caa8896a8a Only compress code in new Function if all arguments are strings. 2013-05-14 18:36:31 +03:00
Mihai Bazon
f64539fb76 Compress code passed to new Function if it's a constant. 
Only for `--unsafe`.

Close #203
 2013-05-14 10:47:06 +03:00
Mihai Bazon
d56ebd7d7b Fix a["1_1"] 
Close #204
 2013-05-14 10:42:34 +03:00
Mihai Bazon
a6ed2c84ac Better fix for equality of typeof ... against "undefined" 2013-05-08 16:22:48 +03:00
Justin Lau
a1958aad56 Fixed typeof undefined optimization and updated related test case to 
accomodates the sort behaviour changes made in commit
mishoo/UglifyJS2@aebafad41e.
Signed-off-by: Justin Lau <justin@tclau.com>
 2013-05-08 16:22:48 +03:00
Justin Lau
9af2bbffde Fixed dot properties not optimizing unicode identifiers. Signed-off-by: Justin Lau <justin@tclau.com> 2013-05-07 14:20:19 +03:00
Justin Lau
1e3bc0caa0 Fixed dot property issue with invlid identifier names. 
Signed-off-by: Justin Lau <justin@tclau.com>
 2013-05-05 22:27:43 +08:00
Michael Ficarra
5af144522a fixes #189: use dotted member access when --screw-ie8 option given 2013-04-20 15:11:05 -05:00
Roman Bataev
4b818056cf Fix typeof evaluation for regex and function 2013-04-03 22:34:38 -04:00
Mihai Bazon
e4b078cff7 Disable unsafe by default 
Close #147
 2013-03-11 00:04:31 +02:00
Mihai Bazon
aebafad41e Fix reordering comparisons 
Close #143
 2013-03-04 10:06:01 +02:00
Mihai Bazon
dac6efb43d Drop last default: if it's the last branch and empty 
Close #141
 2013-03-01 13:12:03 +02:00
Mihai Bazon
8880f4824c Compress boolean constants after evaluation 
Close #137
 2013-03-01 10:26:06 +02:00
Mihai Bazon
3a591c43fe Fix compressing do {...} while (false) 
It's not safe to transform it to {...} because the body might contain
`break`.  The solution could be more elaborate (detect if body contains
`break`) but I don't think it's worth the trouble.

Close #129
 2013-02-19 18:12:19 +02:00
Mihai Bazon
f36e4e9a78 Give up evaluating (unary-prefix '-' 0) 
Close #117

------

    JS, WHY YOU SUCK SO BADLY? ;-(
 2013-02-06 11:51:09 +02:00
Mihai Bazon
9e8ba27dcd Fix handling of constants 
Close #113
 2013-02-06 11:15:31 +02:00
Richard Gibson
522566ea80 Fix #105: property comparison to undefined is not always safe 2013-01-23 23:52:04 -05:00
Mihai Bazon
f0909bdc8f Handle String() with no arguments. 
Fix #91
 2013-01-17 11:01:38 +02:00
Mihai Bazon
31c4a37e37 Optimize new Array(1, 2, 3) → [1, 2, 3] 
Close #74
 2012-12-21 21:04:35 +02:00
Mihai Bazon
16430acc1f small improvement on merging assignments into hoisted vars 2012-12-05 13:14:49 +02:00
Mihai Bazon
320c110b33 When hoisting variables, try to merge in assignments that follow. 2012-12-05 12:30:25 +02:00
Mihai Bazon
5cc90db7d0 Don't messup compressor stack while optimizing Switch 
Fix #59
 2012-11-30 11:16:09 +02:00
Mihai Bazon
4f555e2232 fix for https://github.com/mishoo/UglifyJS/issues/474 2012-11-23 10:20:00 +02:00
Mihai Bazon
0d3fd2ef30 retain (1,eval) as is when it's the expression of an AST_Call 
otherwise we change the meaning of eval from global to lexical.
 2012-11-17 12:05:31 +02:00
Mihai Bazon
bdfcbf496b better solution for the last test in constant switch folding 2012-11-14 12:21:43 +02:00
Mihai Bazon
dba8da4800 optimize constant switch blocks 
ref. mishoo/UglifyJS#441
 2012-11-14 12:06:07 +02:00