JoBoEVD/UglifyJS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
2,162 Commits 3 Branches 341 Tags 23 MiB
bd2f53bc8b
Commit Graph

939 Commits

Author SHA1 Message Date
Alex Lam S.L
f0a99125ee improve unsafe_Func (#2171) 
- minimise disturbance to `compute_char_frequency()`
- remove extraneous quotation marks
 2017-06-27 23:53:42 +08:00
Alex Lam S.L
1e4de2e6d3 parse @global_defs as expressions (#2169) 
- let parser rejects non-conformant input
- eliminate need for extraneous parenthesis
 2017-06-27 10:31:19 +08:00
Alex Lam S.L
9db4c42380 fix cascade & collapse on property access of constants (#2158) 2017-06-24 21:30:06 +08:00
Alex Lam S.L
dc6bcaa18e synchronise mangle.properties for minify() & test/compress (#2151) 2017-06-23 15:53:13 +08:00
Alex Lam S.L
d58b184835 refactor Compressor.toplevel (#2149) 2017-06-23 13:11:40 +08:00
Alex Lam S.L
b3a57ff019 minimise reduce_vars cloning overhead (#2148) 2017-06-23 06:59:53 +08:00
Alex Lam S.L
3d5bc08185 fix reduce_vars on this (#2145) 
fixes #2140
 2017-06-23 04:44:57 +08:00
Alex Lam S.L
0a0f4f5591 make defensive copies when inline (#2116) 
fixes #2114
 2017-06-17 14:32:37 +08:00
Alex Lam S.L
931daa85bf fix loss of context in collapse_vars & cascade (#2112) 
fixes #2110
 2017-06-16 21:18:43 +08:00
Alex Lam S.L
00e4f7b3c1 in-place tigten_body() (#2111) 
By reducing copies of `AST_Node` arrays, we should be able to reduce:
- memory pressure
- potential bugs caused by multiple references in AST
- duplicated executions of `OPT()`
 2017-06-16 19:19:54 +08:00
Alex Lam S.L
11e63bc335 correctly determine scope of AST_This (#2109) 
fixes #2107
 2017-06-16 14:54:46 +08:00
Alex Lam S.L
33405bb24b enforce inline scope restriction (#2106) 
fixes #2105
 2017-06-16 03:21:38 +08:00
Alex Lam S.L
b85a358deb suppress inline of this (#2103) 
fixes #2101
 2017-06-15 12:14:16 +08:00
Alex Lam S.L
2bdc8802dd fix variable accounting in inline (#2085) 
fixes #2084
 2017-06-13 01:40:14 +08:00
Alex Lam S.L
9c306406f1 fix iteration over object with inherited properties (#2068) 
fixes #2055
 2017-06-08 03:27:03 +08:00
Alex Lam S.L
9db0695b10 fix cascade on multi-branch evaluations (#2067) 
Partially reverts #2059 as this has better coverage and performance.

fixes #2062
 2017-06-07 19:52:01 +08:00
Alex Lam S.L
b9ad53d1ab fix inline handling of AST_Call.args (#2059) 2017-06-06 22:55:25 +08:00
Alex Lam S.L
3493a182b2 implement function inlining (#2053) 
- empty body
- single `AST_Return`
- single `AST_SimpleStatement`
- avoid `/*#__PURE__*/`

Miscellaneous
- enhance single-use function substitution

fixes #281
 2017-06-06 05:49:53 +08:00
Alex Lam S.L
540220b91b fix AST_Function scope invariance (#2052) 
improve function name hack in `run_code()`
 2017-06-04 19:27:43 +08:00
Alex Lam S.L
ec095ed647 whitelist unsafe evaluate candidates (#2039) 
- all arguments may accept constant values
- return constant value
- free of side effects
- available & identical across locales and runtime environments
 2017-06-01 04:33:05 +08:00
Alex Lam S.L
17e73121fa enhance unsafe evaluate (#2037) 2017-06-01 00:56:28 +08:00
Alex Lam S.L
e9645e017f introduce unsafe_Func (#2033) 
Separate flag for #203 functionality.
 2017-05-31 03:38:00 +08:00
Alex Lam S.L
1aa38051fb better fix for #512 & #2010 (#2019) 
- remove duplicated functionalities
- fix similar issue with `else`
 2017-05-29 10:51:41 +08:00
Alex Lam S.L
7b13159cda fix hoist_funs on block-scoped function under "use strict" (#2013) 
Technically not part of ES5, but commonly used code exists in the wild.
 2017-05-27 17:44:59 +08:00
Alex Lam S.L
95094b9c22 fix if_return on AST_Defun (#2010) 
Previous fiix for #1052 perturbs declaration order of functions which leads to incorrect behaviour under "use strict".
 2017-05-27 13:41:49 +08:00
Alex Lam S.L
dc33facfcb fix dead_code on block-scoped function under "use strict" (#2006) 
Technically not part of ES5, but commonly used code exists in the wild.
 2017-05-26 16:08:51 +08:00
Alex Lam S.L
efdb65913b improve usability of global_defs in minify() (#1987) 
Use `@key` to `parse()` string value as `AST_Node`.

fixes #1986
 2017-05-22 01:38:43 +08:00
Alex Lam S.L
58fae7dc07 enhance if_return to handle return void... (#1977) 
fixes #512
 2017-05-20 15:58:46 +08:00
Alex Lam S.L
eae26756f1 introduce unsafe_regexp (#1970) 
fixes #1964
 2017-05-19 09:06:29 +08:00
Alex Lam S.L
3ca902258c fix bugs with getter/setter (#1926) 
- `reduce_vars`
- `side_effects`
- property access for object
- `AST_SymbolAccessor` as key names

enhance `test/ufuzz.js`
- add object getter & setter
  - property assignment to setter
  - avoid infinite recursion in setter
- fix & adjust assignment operators
  - 50% `=`
  - 25% `+=`
  - 2.5% each for the rest
- avoid "Invalid array length"
- fix `console.log()`
  - bypass getter
  - curb recursive reference
- deprecate `-E`, always report runtime errors
 2017-05-14 02:10:34 +08:00
Alex Lam S.L
c391576d52 remove support for const (#1910) 
As this is not part of ES5.
 2017-05-12 14:57:41 +08:00
Alex Lam S.L
ac73c5d421 avoid arguments and eval in reduce_vars (#1924) 
fixes #1922
 2017-05-12 12:34:55 +08:00
Alex Lam S.L
1d407e761e fix invalid transform on const (#1919) 
- preserve (re)assignment to `const` for runtime error
- suppress `cascade` on `const`, as runtime behaviour is ill-defined
 2017-05-12 04:51:44 +08:00
Alex Lam S.L
2c7ee956fd fix unsafe on evaluate of reduce_vars (#1870) 
Determine if variables with non-constant values can escape and be modified.

fixes #1865
 2017-05-06 23:18:55 +08:00
Alex Lam S.L
ecf3563c45 kill opera (#1869) 2017-05-06 17:42:07 +08:00
Alex Lam S.L
dee5a27516 enhance collapse_vars (#1862) 
- extend expression types
  - `a++`
  - `a=x;`
- extend scan range
  - `for(init;;);`
  - `switch(expr){case expr:}`
  - `a = x; a = a || y;`
- terminate upon `debugger;`

closes #1821
fixes #27
fixes #315
fixes #1858
 2017-05-06 16:15:43 +08:00
Alex Lam S.L
5a25d24b56 rename variables for better readability (#1863) 2017-05-02 20:47:10 +08:00
kzc
ea9289771b improve literal return optimization (#1860) 2017-05-02 00:10:11 +08:00
Alex Lam S.L
2cb55b2ad0 enforce toplevel on other compress options (#1855) 
Respect "funcs" and "vars" properly.

fixes #1850
 2017-04-30 22:52:36 +08:00
Alex Lam S.L
9e62628171 fix unused on for-in statements (#1843) 
Only need to avoid `var` within the initialisation block.

fixes #1841
 2017-04-24 03:14:01 +08:00
Alex Lam S.L
45ce369480 fix AST_For.init patch-up in drop_unused() (#1839) 
fixes #1838
 2017-04-23 01:51:56 +08:00
Alex Lam S.L
ca32a09032 fix label-related bugs (#1835) 
- deep cloning of `AST_LabeledStatement`
- `L:do{...}while(false)`
- empty statement with label within block

extend `test/ufuzz.js`
- generate labels for blocks & loops
- generate for-in statements
- skip suspicious option search if `minify()` errs


fixes #1833
 2017-04-22 22:15:04 +08:00
Alex Lam S.L
f05d4f7af3 improve unused (#1832) 
- extract leading value with side-effects out of `var` statement
- reduce scanning of `AST_Definitions` from 3 passes to just once
 2017-04-20 13:06:14 +08:00
Alex Lam S.L
88e7a542cd fix unused on labeled for-loop (#1831) 
fixes #1830
 2017-04-20 04:18:38 +08:00
Alex Lam S.L
4dcff038cb improve collapse_vars on AST_Var (#1828) 
Perform the same cascaded scanning within `var` statement as we do on array of statements.
 2017-04-19 04:49:09 +08:00
Alex Lam S.L
28cfb65c47 extend cascade into a.b (#1829) 
fixes #27
 2017-04-19 04:17:15 +08:00
Alex Lam S.L
0f4f01b66c clean up collapse_vars (#1826) 
- remove overlap in functionality of singular, consecutive reference of constant value
- remove workarounds for previous bugs in `lib/scope.js`
- distribute recursive `collapse_single_use_vars()` calls to their respective `OPT(AST_Node)`
- enable collapsing of variables within a single `AST_Definitions`
 2017-04-18 21:45:34 +08:00
Alex Lam S.L
5d9f1da3ab support safe reassignments in reduce_vars (#1823) 
`var a=1;a=2;x(a)` => `x(2)`

fix pre-existing issues
- reference counting on assignment
- walking of anonymous functions
- chained assignment
 2017-04-18 13:38:42 +08:00
Alex Lam S.L
d1aa09c5c7 fix reduce_vars on conditionals (#1822) 2017-04-18 01:44:23 +08:00
Alex Lam S.L
6d5f341999 fix reduce_vars on boolean binary expressions (#1819) 
Side effects of `&&` and `||` have not mattered until #1814, which takes assignment expressions into account.
 2017-04-17 17:24:29 +08:00
Alex Lam S.L
4ffb6fce76 compress duplicated variable definitions (#1817) 
These are surprisingly common, as people reuse the same variable name within loops or switch branches.
 2017-04-17 17:11:29 +08:00
Alex Lam S.L
71a8d0d236 fix reduce_vars within try-block (#1818) 
Possible partial execution due to exceptions.
 2017-04-17 14:03:29 +08:00
Alex Lam S.L
1a498db2d3 enhance reduce_vars (#1814) 
- allow immediate assignment after declaration of variable
- relax modification rule for immutable value
- fix order of visit for TreeWalker
- remove extraneous code
 2017-04-17 01:36:50 +08:00
Alex Lam S.L
44dfa5a318 fix variable substitution (#1816) 
- let `collapse_vars` take care of value containing any symbols
- improve overhead accounting
 2017-04-16 17:25:39 +08:00
Alex Lam S.L
ec443e422c unify CLI & API under minify() (#1811) 
- rename `screw_ie8` to `ie8`
- rename `mangle.except` to `mangle.reserved`
- rename `mangle.properties.ignore_quoted` to `mangle.properties.keep_quoted` 
- compact `sourceMap` options
- more stringent verification on input `options`
- toplevel shorthands
  - `ie8`
  - `keep_fnames`
  - `toplevel`
  - `warnings`
- support arrays and unquoted string values on CLI
- drop `fromString` from `minify()`
  - `minify()` no longer handles any `fs` operations
- unify order of operations for `mangle_properties()` on CLI & API
  - `bin/uglifyjs` used to `mangle_properties()` before even `Compressor`
  - `minify()` used to `mangle_properties()` after `Compressor` but before `mangle_names()`
  - both will now do `Compressor`, `mangle_names()` then `mangle_properties()`
- `options.parse` / `--parse` for parser options beyond `bare_returns`
- add `mangle.properties.builtins` to disable built-in reserved list
  - disable with `--mangle-props builtins` on CLI
- `warnings` now off by default
- add `--warn` and `--verbose` on CLI
- drop `--enclose`
- drop `--export-all`
- drop `--reserved-file`
  - use `--mangle reserved` instead
- drop `--reserve-domprops`
  - enabled by default, disable with `--mangle-props domprops`
- drop `--prefix`
  - use `--source-map base` instead
- drop `--lint`
- remove `bin/extract-props.js`
- limit exposure of internal APIs
- update documentations

closes #96
closes #102
closes #136
closes #166
closes #243
closes #254
closes #261
closes #311
closes #700
closes #748
closes #912
closes #1072
closes #1366
fixes #101
fixes #123
fixes #124
fixes #263
fixes #379
fixes #419
fixes #423
fixes #461
fixes #465
fixes #576
fixes #737
fixes #772
fixes #958
fixes #1036
fixes #1142
fixes #1175
fixes #1220
fixes #1223
fixes #1280
fixes #1359
fixes #1368
 2017-04-15 23:50:50 +08:00
Alex Lam S.L
32deb365d5 drop angular (#1812) 
Remove support for `@ngInject` as there are proper alternatives anyway.
 2017-04-15 05:52:29 +08:00
Alex Lam S.L
2244743545 convert AST_Seq from binary tree to array (#1460) 
- rename `AST_Seq` to `AST_Sequence`
- raise default sequences_limit from 200 to 800
 2017-04-12 21:56:27 +08:00
Alex Lam S.L
d6fbc365e2 fix LHS cases for NaN & friends (#1804) 
`Infinity = beyond` should not become `1/0 = beyond`
 2017-04-09 03:18:14 +08:00
Alex Lam S.L
0479ff0c54 fix a couple of bugs in global_defs (#1802) 
- `optimize()` substituted expression
- compute nested property string correctly

fixes #1801

Miscellaneous
- reset optimisation flags on all node types
 2017-04-08 16:46:25 +08:00
Alex Lam S.L
cf72fe552f fix delete corner cases (#1799) 
- assignment
- boolean
- conditional
- sequence
 2017-04-08 14:25:28 +08:00
Alex Lam S.L
c2a1bceb77 fix pure_getters for chained property access (#1798) 2017-04-07 17:06:01 +08:00
Alex Lam S.L
e3c9c22c75 fix corner cases with delete (#1796) 
`delete Infinity` returns `false` where as `delete (1/0)` returns `true`
 2017-04-07 15:39:59 +08:00
Alex Lam S.L
0f4cd73dcc introduce "strict" to pure_getters (#1795) 2017-04-07 13:31:58 +08:00
Alex Lam S.L
281e882d27 fix reduce_vars on catch variable (#1794) 
Improved catch handling in `figure_out_scope()` means special case treatment of IE8 is no longer valid in `reset_opt_flags()`.

Also fixed recursive assignment in variable definition.
 2017-04-07 12:32:56 +08:00
Alex Lam S.L
cc6aa3e5ac fix incorrect context in variable substitution (#1791) 
`AST_Node.optimize()` is context-aware, so don't cache its results to be used elsewhere.

Also fixed a few cases of AST corruption and beef up safety of `pure_getters`.
 2017-04-07 03:42:17 +08:00
Alex Lam S.L
06cdb74279 improve pure_getters (#1786) 
- property access to `null` & `undefined` always has side effects
- utilise `reduce_vars` to determine safe property access
- may-be cases treated as side effects unless `unsafe`
 2017-04-06 11:18:59 +08:00
Alex Lam S.L
ff289b90a9 implement delayed resolution for reduce_vars (#1788) 
Although it would be nice to enforce `AST_Node` cloning during transformation, that ship has sailed a long time ago.

We now get the assigned value when resolving `AST_SymbolRef` instead of `reset_opt_flags()`, which has the added advantage of improved compressor efficiency.

fixes #1787
 2017-04-05 21:06:42 +08:00
Alex Lam S.L
9b6bc67c33 optimise do{...}while(false) (#1785) 
- better heuristics to avoid issues like #1532
- fix `TreeWalker.loopcontrol_target()`
  - `continue` cannot refer to `switch` blocks
 2017-04-04 23:48:22 +08:00
Alex Lam S.L
9469c03ac9 fix corner case in switch (#1765) 2017-04-02 17:07:20 +08:00
Alex Lam S.L
d57527697f avoid confusion of NaN & Infinity with catch symbol of the same name (#1763) 
fixes #1760
fixes #1761
 2017-04-02 16:14:09 +08:00
Alex Lam S.L
f7ca4f2297 fix corner cases in switch and undefined (#1762) 
- fix side effects in switch condition for singular blocks
- fix `undefined` confusion with local variable
- gate `OPT(AST_Switch)` with `switches`

fixes #1758
fixes #1759
 2017-04-02 14:52:25 +08:00
Alex Lam S.L
ee3fe0f4cd fix switch branch elimination (#1752) 
Merge unreachable case body with previous fallthrough case

fixes #1750
 2017-04-01 17:19:57 +08:00
Alex Lam S.L
257ddc3bdb improve compression of undefined, NaN & Infinitiy (#1748) 
- migrate transformation logic from `OutputStream` to `Compressor`
- always turn `undefined` into `void 0` (unless `unsafe`)
- always keep `NaN` except when avoiding local variable redefinition
- introduce `keep_infinity` to suppress `1/0` transform, except when avoiding local variable redefinition

supersedes #1723
fixes #1730
 2017-04-01 03:02:14 +08:00
Alex Lam S.L
1ddc05725d combine rules for binary boolean operations (#1744) 2017-03-31 18:47:44 +08:00
Alex Lam S.L
a0c3836ba0 sort options in alphabetical order (#1743) 
They started off as functional groups I guess, but given the sheer number of options this is becoming too difficult to read.
 2017-03-31 16:41:04 +08:00
Alex Lam S.L
7cb1adf455 remove paranthesis for -(x*y) (#1732) 2017-03-30 16:09:00 +08:00
Alex Lam S.L
7bea38a05d optimize try-catch-finally (#1731) 
- eliminate empty blocks
- flatten out if try-block does not throw
 2017-03-30 12:16:58 +08:00
Alex Lam S.L
beb9659778 speed up IIFE elimination (#1728) 
- `side_effects` will clean up inner statements, so checking for an empty function body should suffice
- drop side effects when dropping `return` from statement
 2017-03-29 23:27:35 +08:00
Alex Lam S.L
f1a833a7aa speed up equivalent_to() and AST_Switch (#1727) 2017-03-29 22:08:26 +08:00
Alex Lam S.L
09f77c7d4d output optimal representations of NaN & Infinity (#1723) 
- move these optimisations out from `Compressor` to `OutputStream`
- fixes behaviour inconsistency when running uglified code from global or module levels due to redefinition
 2017-03-29 18:31:55 +08:00
Alex Lam S.L
eb48a035e7 fix corner case in unused (#1718) 
When fixing catch-related issue in #1715, it tries to optimise for duplicate definitions but did not take anonymous functions into account.

Remove such optimisation for now and we can cover this as a more general rule later.
 2017-03-29 01:00:21 +08:00
Alex Lam S.L
c909ffb715 fix unused on var of the same name within catch (#1716) 
fixes #1715
 2017-03-28 21:25:49 +08:00
Alex Lam S.L
f71f4905b0 fix is_number() on += (#1714) 
fixes #1710
 2017-03-28 17:08:16 +08:00
Alex Lam S.L
fb177a6312 drop anonymous function name when overshadowed by other declarations (#1712) 
fixes #1709
 2017-03-28 17:02:20 +08:00
Alex Lam S.L
67d0237f73 fix tail trimming of switch blocks (#1707) 
now guarded under `dead_code`

fixes #1705
 2017-03-28 03:59:13 +08:00
Alex Lam S.L
c526da59a1 has_side_effects() should take AST_Switch.expression into account (#1699) 
fixes #1698
 2017-03-27 18:09:35 +08:00
Alex Lam S.L
581630e0a7 fix typeof side effects (#1696) 
`statement_to_expression()` drops `typeof` even if it operates on undeclared variables.

Since we now have `drop_side_effect_free()`, replace and remove this deprecated functionality.
 2017-03-27 04:37:42 +08:00
Alex Lam S.L
f5952933a0 preserve side effects in switch expression (#1694) 
fixes #1690
 2017-03-27 02:32:46 +08:00
Alex Lam S.L
f001e4cb9d fix cascade on anonymous function reference (#1693) 
Unlike normal variables and even function definitions, these cannot be reassigned, even though assignment expressions would "leak" the assigned value as normal.
 2017-03-27 01:58:21 +08:00
Alex Lam S.L
57ce5bd9e0 handle overlapped variable definitions (#1691) 
Process variable definitions with or without assigned values against:
- `arguments`
- named function arguments
- multiple definitions within same scope

Essentially demote variable declarations with no value assignments.

Also fixed invalid use of `AST_VarDef` over `arguments` - should use a member of `AST_SymbolDeclaration` instead.
 2017-03-27 01:30:21 +08:00
Alex Lam S.L
861a79ac9f fix delete related issues in collapse_vars and reduce_vars (#1689) 2017-03-26 19:14:30 +08:00
Alex Lam S.L
e76fb354eb fix cascade on delete operator (#1687) 
Conditions including strict mode would make `delete` return `true` or `false`, and are too complex to be evaluated by the compressor.

Suppress assignment folding into said operator.

fixes #1685
 2017-03-26 18:08:44 +08:00
Alex Lam S.L
3276740779 fallthrough should not execute case expression (#1683) 
- de-duplicate trailing cases only, avoid all potential side-effects
- enable switch statement fuzzing

fixes #1680
 2017-03-26 16:52:38 +08:00
kzc
5509e51098 optimize conditional when condition symbol matches consequent (#1684) 2017-03-26 16:36:33 +08:00
Alex Lam S.L
94f84727ce suppress switch branch de-duplication upon side effects (#1682) 
fixes #1679
 2017-03-26 13:32:43 +08:00
Alex Lam S.L
8a4f86528f fix side-effects detection on switch statements (#1678) 
extension of #1675
 2017-03-26 12:05:44 +08:00
Alex Lam S.L
f83d370f57 improve switch optimisations (#1677) 
- correctly determine reachability of (default) branches
- gracefully handle multiple default branches
- optimise branches with duplicate bodies

fixes #376
fixes #441
fixes #1674
 2017-03-26 05:15:46 +08:00
Alex Lam S.L
b19aa58cff fix has_side_effects() (#1675) 
`AST_Try` is an `AST_Block`, so besides try block we also need to inspect catch and finally blocks for possible side effects.

Also extend this functionality to handle `AST_If` and `AST_LabeledStatement` while we are at it.

fixes #1673
 2017-03-25 23:03:26 +08:00
Alex Lam S.L
0a65de89b9 fix reduce_vars on AST_Switch (#1671) 
Take conditional nature of switch branches into account.

fixes #1670
 2017-03-25 21:17:30 +08:00
Alex Lam S.L
6e86ee950d fix typeof side-effects (#1669) 
`has_side_effects()` does not take `typeof`'s magical power of not tripping over undeclared variable into account.

fixes #1668
 2017-03-25 17:40:18 +08:00
Alex Lam S.L
8ca2401ebe fix dead_code on AST_Switch (#1667) 
Need to call `extract_declarations_from_unreachable_code()`.

fixes #1663
 2017-03-25 16:21:42 +08:00
Alex Lam S.L
a30092e20f fix invalid AST_For.init (#1657) 
Turns out the only place in `Compressor` which can generate invalid `AST_For.init` is within `drop_unused()`, so focus the fix-up efforts.

supercedes #1652
fixes #1656
 2017-03-25 03:18:36 +08:00
Alex Lam S.L
32283a0def fix cascade of evaluate optimisation (#1654) 
Operator has changed, so break out from rest of the rules.

fixes #1649
 2017-03-24 22:09:19 +08:00
Alex Lam S.L
ac51d4c5a0 fix corner case in AST_For.init (#1652) 
Enforce `null` as value for empty initialisation blocks.

fixes #1648
 2017-03-24 19:31:17 +08:00
Alex Lam S.L
0432a7abb9 fix assignment extraction from conditional (#1651) 
fixes #1645
fixes #1646
 2017-03-24 18:52:48 +08:00
Alex Lam S.L
f3a1694a41 fix assignment substitution in sequences (#1643) 
take side effects of binary boolean operations into account

fixes #1639
 2017-03-24 14:30:31 +08:00
Alex Lam S.L
e918748d88 improve collapsible value detection (#1638) 
- #1634 bars variables with cross-scope references in between to collapse
- but if assigned value is side-effect-free, no states can be modified, so it is safe to move
 2017-03-24 02:55:32 +08:00
Alex Lam S.L
48ffbef51d account for cross-scope modifications in collapse_vars (#1634) 
mostly done by @kzc

fixes #1631
 2017-03-23 07:17:34 +08:00
Alex Lam S.L
c0f3feae9f introduce compressor.info() (#1633) 
report the following only when `options.warnings = "verbose"`
- unused elements due to inlining
- collpased variables
 2017-03-23 06:49:49 +08:00
Alex Lam S.L
96f8befdd7 fix commit 88fb83a (#1622) 
The following is wrong:
    `a == (b ? a : c)` => `b`
Because:
- `b` may not be boolean
- `a` might have side effects
- `a == a` is not always `true` (think `NaN`)
- `a == c` is not always `false`
 2017-03-19 11:59:42 +08:00
Alex Lam S.L
cd58635dcc fix AST_Binary.lift_sequences() (#1621) 
Commit eab99a1c fails to account for side effects from compound assignments.
 2017-03-19 03:04:22 +08:00
Alex Lam S.L
274331d0ea transform String.charAt() to index access (#1620) 
Guarded by `unsafe` as `charAt()` can be overridden.
 2017-03-19 02:17:15 +08:00
Alex Lam S.L
ac40301813 fix chained evaluation (#1610) 
`reduce_vars` enables substitution of variables but did not clone the value's `AST_Node`.

This confuses `collapse_vars` and result in invalid AST and subsequent crash.

fixes #1609
 2017-03-17 00:26:48 +08:00
Alex Lam S.L
5ae04b3545 make collapse_vars consistent with toplevel (#1608) 
fixes #1605
 2017-03-16 13:22:26 +08:00
Alex Lam S.L
a80b228d8b fix hoist_vars on reduce_vars (#1607) 
`hoist_vars` converts variable declarations into plain assignments, which then confuses `reduce_vars`

fixes #1606
 2017-03-16 12:03:30 +08:00
Alex Lam S.L
cf4bf4ceb1 fix stack issues with AST_Node.evaluate() (#1603) 
As patched in #1597, `make_node_from_constant()` makes inconsistent and sometimes incorrect calls to `optimize()` and `transform()`.

Fix those issues properly by changing the semantics of `evaluate()` and `make_node_from_constant()`, with the side effect that `evaluate()` no longer eagerly converts constant to `AST_Node`.
 2017-03-16 01:02:59 +08:00
Alex Lam S.L
8223b2e0db fix AST_Node.optimize() (#1602) 
Liberal use of `Compressor.transform()` and `AST_Node.optimize()` presents an issue for look-up operations like `TreeWalker.in_boolean_context()` and `TreeWalker.parent()`.

This is an incremental fix such that `AST_Node.optimize()` would now contain the correct stack information when called correctly.
 2017-03-15 18:44:13 +08:00
Alex Lam S.L
381bd3836e minor clean-ups (#1600) 
- remove obsolete optimisation in `AST_Binary` after #1477
- improve `TreeWalker.has_directive()` readability and resilience against multiple visits
 2017-03-14 13:19:05 +08:00
Alex Lam S.L
e3a3db73ae temporary fix for boolean bug (#1597) 
fixes #1592
 2017-03-11 04:59:55 +08:00
Alex Lam S.L
d9344f30b8 disallow parameter substitution for named IIFEs (#1596) 
Self-referenced function has non-fixed values assigned to its parameters.

Let `unused` & `!keep_fnames` do the scanning, then apply `reduce_vars` only to unnamed functions.

fixes #1595
 2017-03-11 03:34:55 +08:00
Alex Lam S.L
b633706ce4 fix & improve function argument compression (#1584) 
- one-use function call => IIFE should take `eval()` & `arguments` into account
- if unused parameter cannot be eliminated, replace it with `0`

fixes #1583
 2017-03-09 19:11:05 +08:00
Alex Lam S.L
7e465d4a01 scan RHS of dropped assignments (#1581) 
- similar case as #1578 but against #1450 instead
- fix `this` binding in #1450 as well

closes #1580
 2017-03-09 05:22:27 +08:00
Alex Lam S.L
711f88dcb4 scan assignment value in drop_unused() (#1578) 
those were not optimised for `unused` before, which made it necessary for `reduce_vars` to have separate steps for `keep_fnames`

docs update by @kzc

closes #1577
 2017-03-08 18:37:32 +08:00
Alex Lam S.L
c7cdcf06a6 fix function name eliminiation (#1576) 
Function expression can be assigned to a variable and be given a name. Ensure function name is the reduced variable before clearing it out.

fixes #1573
fixes #1575
 2017-03-08 12:39:57 +08:00
Alex Lam S.L
bd6dee52ab fix return from recursive IIFE (#1570) 
`side-effects` did not account for IIFEs being able to reference itself thus making its return value potentially significant
 2017-03-08 03:31:51 +08:00
Alex Lam S.L
8153b7bd8a transform function calls to IIFEs (#1560) 
- expose function body to call sites for potential optimisations
- suppress substitution of variable used within `AST_Defun`
 2017-03-07 15:37:52 +08:00
Alex Lam S.L
d787d70127 avoid substitution of global variables (#1557) 
- unless `toplevel` is enabled
- global `const` works as before
 2017-03-07 03:11:03 +08:00
kzc
3ac2421932 collapse_vars: do not replace a constant in loop condition or init (#1562) 2017-03-07 01:42:33 +08:00
Alex Lam S.L
067e5a5762 fixup for #1553 (#1555) 
- `++a` is the one that is foldable
- transform `a++` into `++a` for better optimisation
 2017-03-05 17:15:37 +08:00
Alex Lam S.L
35a849dc48 collapse assignment with adjacent subsequent usage (#1553) 
- consolidate `cascade` optimisations
- support ++/-- postfixes
- remove redundant optimisation identified in #1460

fixes #368
 2017-03-05 14:56:14 +08:00
Alex Lam S.L
b70591be1a handle variable declaration within catch blocks (#1546) 
accounts for IE8- scoping
 2017-03-05 13:13:44 +08:00
Alex Lam S.L
b33e7f88e6 improve unsafe on undefined (#1548) 
`unsafe` turns undefined keyword into a variable of the same name if found, but that interferes with other related optimisations.

Keep track of such transformations to ensure zero information loss in the process.
 2017-03-05 13:09:27 +08:00
Alex Lam S.L
1f0333e9f1 stay safe with constants in IE8- (#1547) 
- `undefined` etc. can be redefined at top-level for IE8-, so disable related optimisations
- fixed `--support-ie8` catch mangle bug
 2017-03-05 12:51:11 +08:00
Alex Lam S.L
78d1bb92d4 fix a corner case in #1530 (#1552) 2017-03-05 12:12:59 +08:00
kzc
ce54c9ccee disallow collapse_vars constant replacement in for-in statements (#1543) 2017-03-04 02:39:54 +08:00
Alex Lam S.L
07accd2fbb process code with implicit return statement (#1522) 
Bookmarklet for instance implicitedly assumes a "completion value" without using `return`.
The `expression` option now supports such use cases.
Optimisations on IIFEs also enhanced.

fixes #354
fixes #543
fixes #625
fixes #628
fixes #640
closes #1293
 2017-03-03 18:13:07 +08:00
Alex Lam S.L
18059cc94f compress numerical expressions (#1513) 
safe operations
- `a === b` => `a == b`
- `a + -b`  => `a - b`
- `-a + b`  => `b - a`
- `a+ +b`   => `+b+a`

associative operations
(bit-wise operations are safe, otherwise `unsafe_math`)
- `a + (b + c)`       => `(a + b) + c`
- `(n + 2) + 3`       => `5 + n`
- `(2 * n) * 3`       => `6 * n`
- `(a | 1) | (2 | d)` => `(3 | a) | b`

fixes #412
 2017-03-03 18:04:32 +08:00
Alex Lam S.L
b5e0e8c203 facilitate fix for #1531 (#1542) 2017-03-03 07:12:24 +08:00
Alex Lam S.L
17b81350d4 fix chained assignment with unused (#1540) 
When #1450 optimises `a=b=42`, it stops after the first variable even if both are unused.

fixes #1539
 2017-03-03 04:45:20 +08:00
kzc
4d63d4f5b3 collapse_vars should not replace constant in for-in init section (#1538) 
fixes #1537
 2017-03-03 03:51:15 +08:00
Alex Lam S.L
70d72ad806 properly cover all cases of for-in loop variables (#1536) 2017-03-03 02:39:57 +08:00
Alex Lam S.L
fe9227a41b fix reference marking in for-in loops (#1535) 
fixes #1533
 2017-03-03 00:56:06 +08:00
Alex Lam S.L
b49e142a26 disable do{...}while(false) optimisation (#1534) 
- fails to handle `break` in body

fixes #1532
 2017-03-03 00:54:41 +08:00
kzc
ee3b39b909 optimize trivial IIFEs returning constants (#1530) 2017-03-02 15:11:40 +08:00
Alex Lam S.L
9699ffb1af trim unused invocation parameters (#1526) 2017-03-02 11:33:59 +08:00
Alex Lam S.L
fdc9b9413b minor improvement to string optimisation (#1514) 
- "" + "a"     => "a"
- "" + a + "b" => a + "b"
- "a" + ""     => "a" (improving on #45)
 2017-03-02 11:31:39 +08:00
Alex Lam S.L
7aa69117e1 fix corner cases in reduce_vars (#1524) 
Avoid variable substitution in the following cases:
- use of variable before declaration
- declaration within conditional code blocks
- declaration within loop body

fixes #1518
fixes #1525
 2017-03-02 00:20:53 +08:00
Alex Lam S.L
c2334baa48 fix crash on missing props to string_template() (#1523) 
Patched up `make_node()` without `orig`.

There may be other cases where `start` could be missing, so make it print "undefined" instead of crashing.

fixes #1518
 2017-03-01 15:25:26 +08:00
Alex Lam S.L
f5cbe19b75 invert reduce_vars tracking flag (#1519) 
Modules like webpack and grunt-contrib-uglify still uses `ast.transform(compressor)` before `Compressor.compress(ast)` was introduced.

Workaround this compatibility issue by deactivating `reduce_vars` in such case.

Also fix use case with omitted `options` when calling `Compressor()`.

fixes #1516
 2017-03-01 04:12:10 +08:00
Alex Lam S.L
b34fa11a13 fix evaluate on object getter & setter (#1515) 2017-03-01 02:03:47 +08:00
Alex Lam S.L
4365a51237 temporarily disables reduce_vars (#1517) 
... as we investigate #1516
 2017-03-01 00:25:43 +08:00
Alex Lam S.L
858e6c78a4 warn & drop #__PURE__ iff IIFE is dropped (#1511) 
- consolidate `side-effects` optimisations
- improve string `+` optimisation
- enhance literal & `conditionals` optimisations
 2017-02-28 02:25:44 +08:00
Alex Lam S.L
13be50a4a9 faster tree transversal (#1462) 
- convert `[].forEach()` to for-loops
 2017-02-26 05:58:26 +08:00
Alex Lam S.L
16cd5d57a5 consolidate evaluate & reduce_vars (#1505) 
- improve marking efficiency
- apply smarter `const` replacement to `var`

fixes #1501
 2017-02-26 00:40:33 +08:00
alexlamsl
4e49302916 enable collapse_vars & reduce_vars by default 
- fix corner cases in `const` optimisation
- deprecate `/*@const*/`

fixes #1497
closes #1498
 2017-02-24 01:46:57 +08:00
kzc
1e51586996 Support marking a call as pure 
A function call or IIFE with an immediately preceding comment
containing `@__PURE__` or `#__PURE__` is deemed to be a
side-effect-free pure function call and can potentially be
dropped.

Depends on `side_effects` option.

`[#@]__PURE__` hint will be removed from comment when pure
call is dropped.

fixes #1261
closes #1448
 2017-02-21 14:24:18 +08:00
alexlamsl
26fbeece1c fix pure_funcs & improve side_effects 
- only drops side-effect-free arguments
- drop side-effect-free parts with discarded value from `AST_Seq` & `AST_SimpleStatement`

closes #1494
 2017-02-21 13:31:59 +08:00
alexlamsl
ec64acd2c8 introduce unsafe_proto 
- `Array.prototype.slice` => `[].slice`

closes #1491
 2017-02-21 13:29:58 +08:00
alexlamsl
e275148998 enhance global_defs 
- support arrays, objects & AST_Node
- support `"a.b":1` on both cli & API
- emit warning if variable is modified
- override top-level variables

fixes #1416
closes #1198
closes #1469
 2017-02-21 13:29:58 +08:00
alexlamsl
974247c8c0 evaluate AST_SymbolRef as parameter 
fix invalid boolean conversion now exposed in `make_node_from_constant()`

closes #1477
 2017-02-21 13:29:58 +08:00
alexlamsl
a0f4fd390a improve reduce_vars and fix a bug 
- update modified flag between compress() passes
- support IIFE arguments
- fix corner case with multiple definitions

closes #1473
 2017-02-21 13:29:58 +08:00
alexlamsl
b8b133d91a improve keep_fargs & keep_fnames 
- utilise in_use_ids instead of unreferenced()
- drop_unused now up-to-date for subsequent passes

closes #1476
 2017-02-21 13:29:58 +08:00
kzc
6ffbecb72b smarter const replacement taking name length into account 
closes #1459
 2017-02-21 13:29:58 +08:00
alexlamsl
f0ff6189be clean up negate_iife 
- remove extra tree scanning phase for `negate_iife`
- `negate_iife` now only deals with the narrowest form, i.e. IIFE sitting directly under `AST_SimpleStatement`
- `booleans`, `conditionals` etc. will now take care the rest via more accurate accounting
- `a(); void b();` => `a(); b();`

fixes #1288
closes #1451
 2017-02-21 13:29:58 +08:00
alexlamsl
6b3c49e458 improve string concatenation 
shuffle associative operations to minimise parentheses and aid other uglification efforts

closes #1454
 2017-02-21 13:29:57 +08:00
alexlamsl
f584ca8d07 -c sequences=N suboptimal at N expression cutoff 
N = 2:
  a;
  b;
  c;
  d;
was:
  a, b;
  c;
  d;
now:
  a, b;
  c, d;

fixes #1455
closes #1457
 2017-02-21 13:29:57 +08:00
alexlamsl
ae4db00991 tweak do-while loops 
- `do{...}while(false)` => `{...}`
- clean up `AST_While` logic

closes #1452
 2017-02-21 13:29:57 +08:00
alexlamsl
100307ab31 fixes & improvements to [].join() 
fixes
- [a].join() => "" + a
- ["a", , "b"].join() => "a,,b"
- ["a", null, "b"].join() => "a,,b"
- ["a", undefined, "b"].join() => "a,,b"

improvements
- ["a", "b"].join(null) => "anullb"
- ["a", "b"].join(undefined) => "a,b"
- [a + "b", c].join("") => a + "b" + c

closes #1453
 2017-02-21 13:29:57 +08:00
alexlamsl
148047fbbf drop unused: toplevel, assign-only 
- assign statement does not count towards variable usage by default
- only works with assignments on the same scope level as declaration
- can be disabled with `unused` set to "keep_assign"
- `toplevel` to drop unused top-level variables and/or functions
- `top_retain` to whitelist top-level exceptions

closes #1450
 2017-02-21 13:29:57 +08:00
kzc
d11dca3cf9 fix stray else in compress with conditionals=false 
closes #1449
 2017-02-21 13:29:57 +08:00
alexlamsl
e5badb9541 enable typeof "undefined" for general use 
move out of unsafe, guard corner case with screw_id8 instead

closes #1446
 2017-02-18 19:01:42 +08:00
alexlamsl
11676f9d72 fix crash in unsafe replacement of undefined 
remove extraneous call to AST_SymbolRef.reference()

closes #1443
 2017-02-18 18:58:23 +08:00
Anthony Van de Gejuchte
dd31d12a91 Improve optimizing function() { if(c){return foo} bar();} 
closes #1437
 2017-02-18 18:56:18 +08:00
Alex Lam S.L
0610c020b1 optimise binary operands with evaluate() (#1427) 
- remove call to evaluate() in is_constant() and let nested optimize() does its job instead
- reject RegExp in is_constant() and remove special case logic under collapse_vars
- operands to conditionals optimisation are now always evaluate()-ed
- throw error in constant_value() instead of returning undefined to catch possible bugs, similar to make_node_from_constant()
- optimise binary boolean operators under `evaluate` instead of `conditionals`
 2017-01-26 12:16:50 +01:00
Alex Lam S.L
0d7d4918eb augment evaluate to extract within objects (#1425) 
- gated by `unsafe`
- replaces previous optimisation specific to String.length
- "123"[0] => 1
- [1, 2, 3][0] => 1
- [1, 2, 3].length => 3
- does not apply to objects with overridden prototype functions
 2017-01-26 12:14:18 +01:00
alexlamsl
48284844a4 add missing LHS cases which global_defs should avoid 2017-01-19 21:06:28 +01:00
Anthony Van de Gejuchte
79b98a9fe8 Do not overwrite options.comments + cleanup 2016-11-29 20:24:08 +01:00
kzc
fc9804b909 Fix (typeof side_effect()) in boolean context 
Fixes #1289 with suggestion by @rvanvelzen
 2016-10-06 13:50:11 +02:00
alexlamsl
4761d07e0b Optimize unmodified variables 2016-10-01 11:36:11 +02:00
kzc
25fc02743a Account for side effects in string + expr optimization 2016-09-01 09:24:56 -04:00
kzc
0bd8053524 implement optimization: (x = 2 * x) ---> (x *= 2) 2016-08-30 08:43:02 -04:00
Richard van Velzen
8430123e9d Fix negate_iife transform to return a correct tree for nested IIFEs 
Fix for #1256, partially reverts d854523783
 2016-08-17 11:55:59 +02:00
Anthony Van de Gejuchte
7eb52d2837 Keep const in own scope while compressing 
- Fixes #1205
- Fix provided by @kzc
 2016-07-15 13:20:52 +02:00
kzc
b40d5de69c Change the default sequences limit to 200 to speed up compress. 
Has little or no impact on minification size in the majority of
cases but can speed up rollup builds significantly.

This sequences change also has the beneficial side effect of avoiding
"stack size exceeded" errors on very large input files.

The user is free to alter the sequences limit if they are so inclined.
The previous sequences limit was 2000. 20 is often sufficient.
 2016-07-01 09:41:31 +02:00
kzc
b7ef7840f3 Allow sequences maximum length to be user configurable. 2016-07-01 09:41:31 +02:00
kzc
02c638209e Enable --screw-ie8 by default. 
catch identifier is mangled correctly for ES5 standards-compliant JS engines by default.

Unconditionally use the ie8 if/do-while workaround whether or not --screw-ie8 is enabled.

To support non-standard ie8 javascript use: uglifyjs --support-ie8
 2016-06-30 21:49:48 +02:00
kzc
335b72df03 Fix spidermonkey AST (ESTree) export and import, Array holes 
Fixes: #1156 #1161

Also add test to exercise Uglify after spidermonkey export/import of itself.
 2016-06-30 21:44:12 +02:00
kzc
ace8aaa0f4 Fix conditional expressions of form (x ? -1 : -1) 
Fixes #1154, #1153
 2016-06-21 14:52:13 -04:00
kzc
0c003c92a8 Don't replace undefined, NaN and Infinity within with scope 2016-06-21 10:53:29 +02:00
Anthony Van de Gejuchte
d7971ba0e4 Fix test262 failures related to <, <=, in and instanceof 
Fixed-by: @kzc
 2016-06-15 23:11:08 +02:00
Anthony Van de Gejuchte
ea31da2455 Don't drop unused if scope uses with statement 
Fix provided by @kzc
 2016-06-12 14:30:28 +02:00
kzc
09d5707a8a collapse_vars: Do not consider RegExp literals to be constants 
Fixes #1100
 2016-05-27 00:03:51 -04:00
kzc
1e390269d4 Optimize if_return for single if/return cases. 
Fixes #1089
 2016-05-24 17:54:08 +02:00
Richard van Velzen
bc49dfd27a Completely allow evaluating -0 2016-05-24 17:50:29 +02:00
Richard van Velzen
27eedbc302 Never produce -0 when evaluating expressions (like -"") 
Fix for #1085. The major case was already there, but more expressions can result in -0.
 2016-05-17 22:34:38 +02:00
kzc
5f464b41e2 Simplify iife new fix 
as suggested by @rvanvelzen.

Added a test for IIFEs in nested contexts.
 2016-05-15 19:12:17 -04:00
kzc
bcc1318d4b Do not apply negate_iife optimization to new expression 2016-05-09 03:19:28 -04:00
Richard van Velzen
4fe630431c Hoist functions when reversing if (x) return; ... vs. if (!x) ... 
Fixes #1052
 2016-04-23 23:48:33 +02:00
kzc
c55dd5ed74 Add passes compress option. Fix duplicate compress warnings. 2016-04-19 20:05:33 +02:00
Richard van Velzen
4b4528ee05 Prevent endless recursion when evaluating self-referencing consts 
Fix #1041
 2016-04-13 15:03:31 +02:00
Mihai Bazon
b5a7a231f7 Actually limit sequence length. 
Fix #1038
 2016-04-12 14:17:24 +03:00
kzc
3907a5e3b2 Fix warnings for referenced non-hoisted functions. 
Fixes #1034

Also added `expect_warnings` functionality to test framework.
 2016-04-11 18:15:20 +02:00
Mihai Bazon
9317237372 Avoid using inherited hasOwnProperty 
Fix #1031
 2016-04-07 13:16:22 +03:00
kzc
98434258d0 Optimize ternaries with boolean consequent or alternative. 
Fixes #511
 2016-04-02 17:22:12 +02:00
kzc
45ddb9caeb Speedup unused compress option for already minified code 
Fixes: #321 #917 #1022
 2016-03-28 17:58:50 -04:00
kzc
11b0efdf84 boolean_expression ? true : false --> boolean_expression 2016-02-22 17:59:36 +01:00
kzc
5486b68850 Take operator || precendence into account for AST_If optimization. 
Fixes #979.
 2016-02-21 12:05:02 -05:00
alexlamsl
6547437725 preserve ThisBinding for side_effects 2016-02-17 19:34:01 +01:00
Richard van Velzen
9662228f6a Don't compress (0, eval)() to eval() 2016-02-16 19:00:48 +01:00
alexlamsl
31a9b05c96 Preserve ThisBinding in conditionals & collapse_vars 
Fixes #973
 2016-02-16 18:47:49 +01:00
kzc
7c3fee9e31 collapse_vars: avoid replacement across AST_Case nodes to be on safe side even though no issues seen. 2016-01-29 10:35:07 -05:00
kzc
929de2b0de collapse_vars: fix if/else and ternary operator side effects 2016-01-28 12:17:06 -05:00
kzc
af2472d85e collapse_vars: fix bug in repeated var defs of same name 2016-01-28 16:48:50 +01:00
kzc
0a38a688f9 fix bug in collapse_vars for right side of "||" and "&&" 2016-01-27 14:18:46 -05:00
kzc
f4c2ea37bf Collapse single use var definitions 
Fix #721
 2016-01-27 11:48:15 +02:00
Mihai Bazon
fe4e9f9d97 Fix hoisting the var in ForIn 
Close #913
 2016-01-05 13:56:52 +02:00
kzc
774bda13cd #873 Fix conditionals optimizations with default compress options 2015-11-24 13:27:50 -05:00
Mihai Bazon
7f48d5b33c Fix endless loop 
Close #866
 2015-11-16 12:08:24 +02:00
Mihai Bazon
b6968b6bd2 Limit max iterations for tighten_body 
Ref #866
 2015-11-16 12:08:24 +02:00
Mihai Bazon
7691bebea5 Rework has_directive 
It's now available during tree walking, i.e. walker.has_directive("use
asm"), rather than as part of the scope.  It's thus no longer necessary
to call `figure_out_scope` before codegen.  Added special bits in the
code generator to overcome the fact that it doesn't inherit from
TreeWalker.

Fix #861
 2015-11-11 22:15:25 +02:00
kzc
bd0ae6569f return undefined optimization no longer uses return_void_0 option 2015-10-29 08:19:12 +01:00
kzc
7491d07666 optimize return undefined and return void 0 2015-10-29 08:19:12 +01:00
kzc
593677d2ff Add proper support for "use asm"; blocks. Disable -c optimization within "use asm"; sections and preserve floating point literals in their original form. Non-asm.js sections are optimized as before. Asm.js sections can still be mangled and minified of whitespace. No special command line flags are required. 2015-10-07 10:00:28 +02:00
Ville Lautanala
5fd12451f9 Control keeping function arguments with a single option 2015-09-14 19:38:45 +02:00
Richard van Velzen
e3bd223dac Don't change sequences that influence lexical binding in calls 
Fixes #782
 2015-08-25 10:53:35 +02:00
Christopher Chedeau
3ff0b9e0c9 [Fix] --define replaces SymbolRefs in LHS of assignments 
See #208 for context
 2015-08-10 11:22:36 -07:00
thorn0
252fc65558 Advanced way to specify if a function call might have side effects. #400 2015-07-29 14:36:42 +02:00
Mihai Bazon
905b601178 Don't attempt to negate non-boolean AST_Binary 
Fix #751
 2015-07-22 16:55:55 +03:00
Mihai Bazon
63fb2d5a44 Merge pull request #735 from kzc/master 
optimizations for && and || where left side is constant expression
 2015-07-20 09:58:01 +03:00
Mihai Bazon
85a5fc0aeb Don't drop parens in a * (b * c). Close #744 2015-06-30 10:10:29 +03:00
kzc
f47b2b52a5 operator && and || optimization: add "else" before "if" as intended 2015-06-14 17:44:26 -04:00
kzc
fedb6191a1 optimizations for && and || where left side is constant expression 2015-06-11 23:22:38 -04:00
Mihai Bazon
a5b60217ce Fix compressing conditionals 
Only transform foo() ? EXP(x) : EXP(y) into EXP(foo() ? x : y) if EXP has no
side effects.

Fix #710
 2015-05-18 13:56:04 +03:00
Mihai Bazon
c3a10c135e Avoid spurious brackets when dropping unused vars 
Fix #702
 2015-05-04 14:49:17 +03:00
Mihai Bazon
274e1b3dc7 Drop NaN -> 0/0 transformation. 
Fix #687
 2015-04-17 11:26:36 +03:00
Mihai Bazon
18c63ff3d8 Fix compression of conditionals 
Don't move the condition on the right side of an assignment when
the left side may have side effects.

Fix #677
 2015-04-13 17:29:48 +03:00
Mihai Bazon
276b9a31cd Fix compressing ![foo()]; as a statement 
need to check whether the literal has any side effects before replacing that
with `false`.
 2015-03-23 23:27:00 +02:00
Mihai Bazon
5801fa39e9 [sequencesize] Actually even better: 
do create the sequence even if the stat list is bigger than 2000 statements,
but limit the sequence itself to 2000 expressions.

Ref #414
 2015-03-22 13:02:45 +02:00
Mihai Bazon
f0ab1b02e6 Avoid sequencesize for more than 2000 statements. 
It hardly saves any bytes for a sequence so long, and it risks blowing the
stack with the recursive Seq functions.

Ref #414
 2015-03-22 12:51:15 +02:00
Mihai Bazon
36c28e02fd Add start/end nodes for NaN/Infinity transformations 2015-03-22 12:50:36 +02:00
Mihai Bazon
ecfd881ac6 Keep unused function arguments by default 
Discarding unused function arguments affects function.length, which can lead
to some hard to debug issues.  This optimization is now done only in "unsafe
mode".

Fix #121
 2015-03-20 10:28:51 +02:00
Richard van Velzen
992b6b9fcc Fix invalid removal of left side in && and || compression 
See #637. This does not produce the optimal result, but it does prevent the removal of non-side-effect-free code.
 2015-02-11 21:08:41 +01:00
Richard van Velzen
605362f89d Drop all console statements properly 
Because the base reference can be an member expression as well, we have to dig a bit deeper to find the leftmost base reference.

Fixes #451
 2015-01-31 13:24:44 +01:00
Tal Ater
a1a4c2ada7 Optimize conditionals where the consequent and alternative are both booleans and not equivalent 2015-01-13 18:27:21 +01:00
Richard van Velzen
42ecd42ac0 Replace the correct node when replacing in void sequences 
Close #611.
 2015-01-12 17:09:34 +01:00
Mihai Bazon
a10f6a96d7 Merge pull request #482 from arty-name/inline-ng-inject 
added @ngInject support for inline functions
 2015-01-11 12:10:42 +02:00
Mihai Bazon
61c233a08e Fix make_node_from_constant for Regexp-s 
Close #588
 2015-01-07 11:20:04 +02:00
Mihai Bazon
d2d716483a aborts(AST_If) returns the if node 
Previously it returned the abort node from the alternative branch.  This is
not much use as it can be different from the one in the body
branch (i.e. return vs. throw) and can trick us into issues like #591.

Fix #591
 2015-01-06 14:01:35 +02:00
Mihai Bazon
e1f0747e4c Support keep_fnames in compressor, and --keep-fnames. #552 
Passing `--keep-fnames` will enable it both for compressor/mangler, so that
function names will not be dropped (when unused) nor mangled.
 2015-01-05 11:03:13 +02:00
Richard van Velzen
f4d36a58c2 Fix #569 
When no arguments are given to `new Function()`, it should be treated as
a regular anonymous function (http://es5.github.io/#x15.3.2.1)
 2015-01-04 13:37:59 +01:00
Richard van Velzen
c75f5a1fd8 Fix #597 
NaN and Infinity were replaced in the output generation, instead of
during compression. This could lead to results where `1/0` was inserted
without parens leading to invalid output.

The nodes are replaced in the compression step now, and the output
generation returns their regular names. This should not be a problem,
since they're already only constructed from the original name.
 2014-12-31 12:23:00 +01:00
Mihai Bazon
01d19b4b52 Referencing a global is assumed to have side effects. 
Close #550
 2014-09-28 11:18:25 +03:00
Tal Ater
fb0ec720a4 Compress conditions that have side effects using sequences 2014-09-04 02:57:49 +03:00
Tal Ater
885835a655 Compress conditional assignments where all possible outcomes are equivalant and condition has no side effects 2014-09-02 23:30:25 +03:00
Mihai Bazon
4c64554808 Turn foo.new into foo["new"] when not --screw-ie8. Fix #534 2014-08-26 10:11:01 +03:00
Mihai Bazon
548beeb6b1 Prevent error for Function(""). Close #538 2014-08-20 09:16:34 +03:00
Dan Wolff
8511e80f48 Evaluate "foo".length ==> 3 2014-07-01 11:06:51 +03:00
Artemy Tregubenko
524a8a42a4 added @ngInject support for inline functions 2014-05-11 14:01:08 +02:00
Mihai Bazon
ef2ef07cbd Add option keep_fargs. 
By default it's `false`.  Pass `true` if you need to keep unused function
arguments.

Close #188.
 2014-02-08 12:33:56 +02:00
Matt Basta
ac0086a745 Simplify nested conditionals if possible 2014-02-06 12:39:13 -08:00
Mihai Bazon
5344b7dab8 Fix if_return dropping the alternative. Close #413 2014-01-31 10:44:13 +02:00
Mihai Bazon
c3087dd179 Better process_for_angular before other statement reductions. #395 2014-01-08 11:39:24 +02:00
Mihai Bazon
2c305af478 Support @ngInject with angular compressor option. Close #395. 2014-01-08 11:28:32 +02:00
Mihai Bazon
2c88eb6fbe doh. 2014-01-07 12:54:14 +02:00
Mihai Bazon
27142df4f5 minor: exp["10"] => exp[10] 2014-01-07 12:48:21 +02:00
Mihai Bazon
b521b4b926 Conditional/call optimization 
foo ? bar(x) : bar(y)  ==>  bar(foo ? x : y)
 2013-12-29 10:31:30 +02:00
Mihai Bazon
5a083a938d Optimize seq,void 0. Close #377. 
(x, void 0)    => void x
    (x, undefined) => void x
 2013-12-22 11:36:45 +02:00
Mihai Bazon
dc5f70eab5 Add drop_console option to the compressor 2013-12-10 19:44:41 +02:00
Mihai Bazon
df8c5623af minor 2013-12-10 19:39:03 +02:00
Mihai Bazon
d2190c2bf3 Properly scope catch identifier when --screw-ie8 
Fix #344
 2013-11-28 16:43:30 +02:00
Mihai Bazon
50b8d7272c Fix faulty compression 
`String(x + 5)` is not always the same as `x + "5"`.  Overlooked that. :-(

Close #350
 2013-11-20 21:13:16 +02:00
Mihai Bazon
7d11b96f48 Only descend twice after drop_unused if it's the same node type. 
Fix #345
 2013-11-08 11:57:17 +02:00
Mihai Bazon
eab99a1c3d Better fix for #343 
We can in fact lift sequences, but only if the operation is assignment and
the left-hand side has no side effects nor property access -- that should
guarantee that whatever we place before it cannot affect the sense of the
assignment.

Dropped contrived test case (too hard to support it now), added a more
meaningful one.
 2013-11-06 10:48:48 +02:00
Mihai Bazon
f4919e3a25 Do not lift sequence from right-hand side of binary operation. Fix #343 2013-11-06 10:18:28 +02:00
Mihai Bazon
b70670b69f Fix regression after e4c5302406 
`x * (y * z)` ==> `x * y * z` -- the better place to do this is in the
compressor rather than codegen.
 2013-10-30 10:45:58 +02:00
Mihai Bazon
9dd97605bc indentation 2013-10-30 10:44:50 +02:00
Richard van Velzen
785c6064cc Disallow reversal where lhs has higher or equal precedence 
Fixes #267
 2013-10-29 21:37:36 +01:00
Richard van Velzen
e2daee9a65 Fix RHS concat (raised in #330) 
When attempting to concat the left-side of the rhs, make sure the rhs is
a string.
 2013-10-26 18:44:52 +02:00
Richard van Velzen
1a5a4bd631 Fix #269 
Shorten most primitives where possible. Also optimize some edge cases.
 2013-10-24 11:08:33 +02:00
Richard van Velzen
7055af8221 Fix #280 
The `init` of the `ForStatement` is not a `BlockStatement` before it was
descended. The descend has to happen first, and *then* the actual
checks.
 2013-10-23 22:26:04 +02:00
Mihai Bazon
63d04fff69 Revert #3a81f60 for now 
(with it some tests break and it can generate invalid output, see issue #44)
 2013-10-22 21:50:55 +03:00
Mihai Bazon
3fa9265ce4 wrap up 2013-10-09 22:15:43 +03:00
Mihai Bazon
3a81f60982 Don't drop_unused before compression. 
Fix #280, #282
 2013-10-09 19:15:09 +03:00
Mihai Bazon
f2348dd98b Rename clean_getters to pure_getters; add pure_funcs. 2013-10-04 13:17:25 +03:00
Mihai Bazon
8cc86fee60 add clean_getters compressor option (default false) 
allows one to specify if `foo.bar` is considered to have side effects.
 2013-10-02 19:38:01 +03:00
Mihai Bazon
88fb83aa81 minor optimization 
unlikely to help in hand-written code:

    (something() ? foo : bar) == foo  ==>  something()
 2013-10-02 15:31:31 +03:00
Mihai Bazon
95b4507c02 Fix error in the output minifying Function("return this")() 2013-09-30 11:49:29 +03:00
Mihai Bazon
afdaeba37d More attempts to determine when addition is associative 
Somebody hit me with bug reports on this. :)

Refs #300
 2013-09-22 15:26:10 +03:00
Mihai Bazon
037199bfe2 Actually let's move away those monsters from the evaluate function 
ev() should do a single thing — evaluate constant expressions.  if that's
not possible, just return the original node.  it's not the best place for
partial evaluation there, instead doing it in the compress functions.
 2013-09-22 15:00:42 +03:00
Mihai Bazon
583fac0a0f More dirty handling of [ ... ].join() in unsafe mode 
Close #300
 2013-09-22 13:14:42 +03:00
Dan Wolff
e8158279ff Evaluate [...].join() if possible: minor bugfix 
Follow-up to 78e98d2.
 2013-09-22 11:34:30 +03:00
Mihai Bazon
78e98d2611 When unsafe is set, evaluate [...].join() if possible 
Close #298
 2013-09-19 18:20:45 +03:00
Dan Wolff
8d14efe818 Concatenate strings also on the right-hand side of an expression that cannot be evaluated. Fix #126 
E.g. converts:
  a+'Hello'+'World'
to
  a+'HelloWorld'
 2013-09-19 13:03:03 +03:00
Mihai Bazon
85b527ba3d Disallow continue referring to a non-IterationStatement. Fix #287 
Simplifies handling of labels (their definition/references can be easily
figured out at parse time, no need to do it in `figure_out_scope`).
 2013-09-02 19:36:16 +03:00
Mihai Bazon
ed80b4a534 Move support for negate_iife in the compressor, rather than code generator 
(the code generator doesn't maintain enough context to know whether
the return value is important or discarded)

Fixes #272
 2013-08-20 17:45:52 +03:00
Michael Ficarra
d9ad3c7cbf fixes #259: don't unnecessarily quote object properties when --screw-ie8 2013-08-18 19:45:06 -05:00
Mihai Bazon
4c4dc2137c Don't drop unused setter argument. 
Fix #257
 2013-08-07 12:04:58 +03:00
Mihai Bazon
964d5b9aa4 Don't pretend to evaluate lambdas 
Fix #255
 2013-08-04 21:44:17 +03:00
Mihai Bazon
41c627379c Reverting "added option for dropping unused params" 
Revert "added option for dropping unused params"

(turns out we already had the `unused` option for this.)

This reverts commit e54df2226f.
 2013-07-25 18:08:36 +03:00
Dusan Bartos
e54df2226f added option for dropping unused params 2013-07-25 17:37:47 +03:00
Mihai Bazon
02a84385a0 Don't swap binary ops when "use asm" is in effect. 
Refs #167
 2013-06-07 12:52:09 +03:00
Mihai Bazon
caa8896a8a Only compress code in new Function if all arguments are strings. 2013-05-14 18:36:31 +03:00
Mihai Bazon
f64539fb76 Compress code passed to new Function if it's a constant. 
Only for `--unsafe`.

Close #203
 2013-05-14 10:47:06 +03:00
Mihai Bazon
d56ebd7d7b Fix a["1_1"] 
Close #204
 2013-05-14 10:42:34 +03:00
Mihai Bazon
a6ed2c84ac Better fix for equality of typeof ... against "undefined" 2013-05-08 16:22:48 +03:00
Justin Lau
a1958aad56 Fixed typeof undefined optimization and updated related test case to 
accomodates the sort behaviour changes made in commit
mishoo/UglifyJS2@aebafad41e.
Signed-off-by: Justin Lau <justin@tclau.com>
 2013-05-08 16:22:48 +03:00
Justin Lau
9af2bbffde Fixed dot properties not optimizing unicode identifiers. Signed-off-by: Justin Lau <justin@tclau.com> 2013-05-07 14:20:19 +03:00
Justin Lau
1e3bc0caa0 Fixed dot property issue with invlid identifier names. 
Signed-off-by: Justin Lau <justin@tclau.com>
 2013-05-05 22:27:43 +08:00
Michael Ficarra
5af144522a fixes #189: use dotted member access when --screw-ie8 option given 2013-04-20 15:11:05 -05:00
Roman Bataev
4b818056cf Fix typeof evaluation for regex and function 2013-04-03 22:34:38 -04:00
Mihai Bazon
e4b078cff7 Disable unsafe by default 
Close #147
 2013-03-11 00:04:31 +02:00
Mihai Bazon
aebafad41e Fix reordering comparisons 
Close #143
 2013-03-04 10:06:01 +02:00
Mihai Bazon
dac6efb43d Drop last default: if it's the last branch and empty 
Close #141
 2013-03-01 13:12:03 +02:00
Mihai Bazon
8880f4824c Compress boolean constants after evaluation 
Close #137
 2013-03-01 10:26:06 +02:00
Mihai Bazon
3a591c43fe Fix compressing do {...} while (false) 
It's not safe to transform it to {...} because the body might contain
`break`.  The solution could be more elaborate (detect if body contains
`break`) but I don't think it's worth the trouble.

Close #129
 2013-02-19 18:12:19 +02:00
Mihai Bazon
f36e4e9a78 Give up evaluating (unary-prefix '-' 0) 
Close #117

------

    JS, WHY YOU SUCK SO BADLY? ;-(
 2013-02-06 11:51:09 +02:00
Mihai Bazon
9e8ba27dcd Fix handling of constants 
Close #113
 2013-02-06 11:15:31 +02:00
Richard Gibson
522566ea80 Fix #105: property comparison to undefined is not always safe 2013-01-23 23:52:04 -05:00
Mihai Bazon
f0909bdc8f Handle String() with no arguments. 
Fix #91
 2013-01-17 11:01:38 +02:00
Mihai Bazon
31c4a37e37 Optimize new Array(1, 2, 3) → [1, 2, 3] 
Close #74
 2012-12-21 21:04:35 +02:00
Mihai Bazon
16430acc1f small improvement on merging assignments into hoisted vars 2012-12-05 13:14:49 +02:00
Mihai Bazon
320c110b33 When hoisting variables, try to merge in assignments that follow. 2012-12-05 12:30:25 +02:00
Mihai Bazon
5cc90db7d0 Don't messup compressor stack while optimizing Switch 
Fix #59
 2012-11-30 11:16:09 +02:00
Mihai Bazon
4f555e2232 fix for https://github.com/mishoo/UglifyJS/issues/474 2012-11-23 10:20:00 +02:00
Mihai Bazon
0d3fd2ef30 retain (1,eval) as is when it's the expression of an AST_Call 
otherwise we change the meaning of eval from global to lexical.
 2012-11-17 12:05:31 +02:00
Mihai Bazon
bdfcbf496b better solution for the last test in constant switch folding 2012-11-14 12:21:43 +02:00
Mihai Bazon
dba8da4800 optimize constant switch blocks 
ref. mishoo/UglifyJS#441
 2012-11-14 12:06:07 +02:00
Mihai Bazon
60c0f40250 Merge branch 'optimize_concat' of https://github.com/rvanvelzen/UglifyJS2 into rvanvelzen-optimize_concat 2012-11-13 14:38:55 +02:00
Mihai Bazon
e02771a5f2 don't change order in binary expressions if both operands have side effects 2012-11-13 14:32:07 +02:00
Richard van Velzen
f96f796f71 Add simple optimization for empty-string concats. 
ref. #43
 2012-11-12 15:41:03 +01:00
Mihai Bazon
53355bdb24 fix invalid AST produced by dropping unused variable 
close #44
 2012-11-12 13:23:57 +02:00
Dan Wolff
b49230ab8d convert x.toString() to ""+x instead of x+"" 
In some places this can save one byte in whitespace, e.g. after return.
Example:

function f(arg) {
        // return""+arg - no space between return and ""
        return arg.toString();
}
 2012-11-11 15:53:34 +02:00
Mihai Bazon
1e5e13ed81 AST_LabelRef no longer inherits from AST_SymbolRef 2012-11-08 15:39:14 +02:00
Mihai Bazon
1a5fd3e052 optimization for if/break as first statement in a loop body 
for(...; x; ...) if (y) break; → for(...; x&&!y; ...);

similarly for `while` and some combinations (i.e. the `break` appears in the
`else` clause, etc.)
 2012-11-08 11:43:14 +02:00
Mihai Bazon
ffccb233e5 convert while into for 2012-11-05 16:01:20 +02:00
Mihai Bazon
fba0c1aafe minor 2012-11-05 16:01:09 +02:00
Mihai Bazon
774f2ded94 minor optimization 
for `==` or `!=` against a constant, prefer to display the constant first.
should help a bit after gzip, i.e.:

    typeof foo=="undefined"
    ^^^^^^    ^^^^^^^^^^^^^

vs:

    "undefined"==typeof foo
    ^^^^^^^^^^^^^^^^^^^     (longer sequence that could repeat)

idea stolen from closure.
 2012-11-05 13:13:06 +02:00
Mihai Bazon
8413787efc use a Dictionary object instead of plain object for hashes 
to mitigate the `__proto__` issue

related to #30
 2012-11-02 10:58:45 +02:00
Mihai Bazon
cf409800be it's safe to negate expression in !EXP only in boolean context 
#kendo
 2012-11-01 15:49:05 +02:00
Mihai Bazon
18270dd9f3 added unsafe_comps for negating <= with > 
since it has the potential to break code, let's keep it disabled by default
 2012-11-01 15:14:56 +02:00
Mihai Bazon
d4c25c571b fix compressing UnaryPrefix 
only try negating the expression if the operator is `!`

#kendo
 2012-11-01 13:35:08 +02:00
Mihai Bazon
abe0ebbf02 don't move expressions containing the binary in operator into the for initializer 
(opera can't parse it)

close #25
 2012-10-30 14:50:47 +02:00
Mihai Bazon
70fd2b1f33 fix for if (...) return; else return ...; 
(it was assumed that the first `return` always contains a value)

close #22
 2012-10-24 09:33:32 +03:00
Mihai Bazon
30faaf13ed more sequence optimizations (lift some sequences above binary/unary expressions so that we can avoid parens) 2012-10-22 11:58:06 +03:00
Mihai Bazon
fc8314e810 minor fix for dropping unused definitions. 
function f(x, y) {
        var g = function() { return h() };
        var h = function() { return g() };
        return x + y;
    }

now compresses to `function f(x, y) { return x + y }`
 2012-10-19 12:57:29 +03:00
Mihai Bazon
afb7faa6fa more optimizations for some break/continue cases 2012-10-18 15:14:57 +03:00
Mihai Bazon
253bd8559b more small optimizations 
(unlikely to help for hand-written code)
 2012-10-17 21:57:08 +03:00
Mihai Bazon
6a099fba66 define aborts on AST_If: true if both branches abort 2012-10-17 16:17:14 +03:00
Mihai Bazon
a21f3c6cdd employ a better parser for command-line arguments 
to support passing commas in strings in for example:

    uglifyjs2 -cd TEST="'a,b'" <<EOF
    console.log(TEST);
    EOF

    → console.log("a,b")

close #14
 2012-10-17 15:56:45 +03:00
Mihai Bazon
fcc0229087 drop unused function arguments 
also add test for "drop_unused" (the last one fails for now)
 2012-10-13 15:04:44 +03:00
Mihai Bazon
851b48e4a3 fix compressing benchmark.js (it tried to evaluate a statement) 
the following code in benchmark.js triggered the issue:

    support.decompilation = Function(
      'return (' + (function(x) { return { 'x': '' + (1 + x) + '', 'y': 0 }; }) + ')'
    )()(0).x === '1';

technically that could be resolved into a constant expression, but seems
it's being used here for browser bugs detection :-\
 2012-10-13 12:57:10 +03:00
Mihai Bazon
1b6f8d463f remove the $self hack 
operations are destructive anyway, so there's no point to clone the nodes in
the transformer.  speed++
 2012-10-12 11:07:35 +03:00
Mihai Bazon
172aa7a93c cleanup 
- use prototype-less objects where feasible (minor speed improvement)
- get rid of HOP
 2012-10-11 11:07:42 +03:00
Mihai Bazon
c5ecbfc756 drop unused variable 2012-10-10 11:27:06 +03:00
Mihai Bazon
86182afa7f minor 2012-10-09 22:56:59 +03:00
Mihai Bazon
a84d07e312 add AST_Infinity node 2012-10-09 18:35:53 +03:00
Mihai Bazon
1b0aab2ce9 added $propdoc to AST nodes and some cleanups 
hopefully we can make the AST documentation self-generating
 2012-10-09 18:20:39 +03:00
Mihai Bazon
9ead49641d minor AST cleanup (AST_BlockStatement may inherit from AST_Block) 2012-10-09 13:59:17 +03:00
Mihai Bazon
2c025f23db fix detecting symbols in use 2012-10-09 13:13:55 +03:00
Mihai Bazon
093a9031dc eliminate redundant directives in the same scope 2012-10-08 12:53:17 +03:00
Mihai Bazon
4a2b91220a minor 2012-10-05 20:24:56 +03:00
Mihai Bazon
a1e0885930 replace (function(){ ...no side effects ... })() with undefined. 2012-10-05 16:51:16 +03:00
Mihai Bazon
682a58a1f5 removed some unused variables 2012-10-04 08:49:18 +03:00
Mihai Bazon
11863d6f9a more cleanup (dropped AST_SwitchBlock) 2012-10-03 15:52:31 +03:00
Mihai Bazon
3412498795 AST cleanup (dropped AST_StatementBase) 2012-10-03 15:41:11 +03:00
Mihai Bazon
c11de17e99 added option for side-effect-free statements, fix test 2012-10-03 13:08:03 +03:00
Mihai Bazon
e0f5075e45 fix endless loop in tests 2012-10-03 12:49:47 +03:00
Mihai Bazon
0678ae2076 fix for a = !b && !c && !d && !e → a=!(b||c||d||e) 2012-10-03 11:34:05 +03:00
Mihai Bazon
378ed17809 disable hoist_vars by default and change comparations to comparisons 2012-10-03 11:27:05 +03:00
Mihai Bazon
dde5b22b5e support defines 2012-10-02 13:20:07 +03:00
Mihai Bazon
e1098b04a7 "use strict"; 2012-10-02 12:45:58 +03:00
Mihai Bazon
211792757c more constant folding (for names defined with const) 2012-10-02 12:45:17 +03:00
Mihai Bazon
ff696cd7bc drop more unused names 2012-10-02 12:02:33 +03:00
Mihai Bazon
9e5dd81f1e a shy attempt to obey width in the beautifier; added bracketize option to always print brackets around if/do/while/for statements; export more options via the CLI 2012-10-02 11:22:38 +03:00
Mihai Bazon
13278c6649 removed the "squeeze" method (it's now effectively "transform") 2012-09-26 19:52:32 +03:00
Mihai Bazon
15d58f5917 some speedup and more savings from unused vars that have side effects in initialization 2012-09-26 19:05:49 +03:00
Mihai Bazon
78be8f5296 compressor successfully moved to TreeTransformer 2012-09-26 14:27:01 +03:00
Mihai Bazon
a24e7ee976 checkpoint (refactoring, WIP) 2012-09-26 12:16:16 +03:00
Mihai Bazon
242dd10131 more cleanups 2012-09-25 20:39:15 +03:00
Mihai Bazon
9321d418bc moving code around (refactoring, WIP) 2012-09-25 15:59:27 +03:00
Mihai Bazon
4201577dd7 started some refactoring (WIP) -- moving squeezer to TreeTransformer 2012-09-25 15:15:47 +03:00
Mihai Bazon
e836e2ae5f minor 2012-09-25 12:48:36 +03:00
Mihai Bazon
ea6d1ea701 it's not safe to assume that property access is side-effect-free 
(getters/setters + various browser bugs will trigger side effects; also, an
exception is thrown when the expression is undefined)
 2012-09-25 10:32:14 +03:00
Mihai Bazon
368ac8f93c some boolean cleanup 2012-09-25 10:31:03 +03:00
Mihai Bazon
a83b28503f properly drop mutually-referring declarations that are not otherwise 
referenced and have no side effects
 2012-09-23 12:47:34 +03:00
Mihai Bazon
76d88b59dc tree transformer api (WIP) 2012-09-22 19:41:09 +03:00
Mihai Bazon
ec7f895b54 log filename in parse errors / compressor warnings 2012-09-21 14:44:25 +03:00
Mihai Bazon
c4f8c2103f more on detecting side effects 2012-09-21 11:23:44 +03:00
Mihai Bazon
e8da72d304 drop unused variables 2012-09-19 12:27:38 +03:00
Mihai Bazon
3da0ac4897 support for directives 2012-09-18 13:21:09 +03:00
Mihai Bazon
21968285e8 added AST_NaN (output as 0/0) 2012-09-18 10:53:46 +03:00
Mihai Bazon
d91613b4a8 only do the typeof x == "undefined" optimization if x is a symbol reference and it's declared in scope, or x is not a symbol reference. 2012-09-17 20:02:57 +03:00
Mihai Bazon
ee669ba878 moved typeof foo == "undefined" ==> foo === undefined under --unsafe 
because 43fd45154b (commitcomment-1864505)
 2012-09-17 18:49:52 +03:00
Mihai Bazon
e370e3b5a4 fix .undeclared (it's now a function) 2012-09-17 15:06:06 +03:00
Mihai Bazon
6ad414ef28 minor 2012-09-17 14:33:36 +03:00
Mihai Bazon
92e22c460d possible optimization for AST_Undefined 
if undefined is defined, ;-), we replace AST_Undefined nodes to a reference
to the "undefined" variable; in turn the mangler will compress it to a
single letter; this helps at least on jQuery.
 2012-09-17 12:27:32 +03:00
Mihai Bazon
14481de0e9 empty block to empty statement: {} ==> ; 2012-09-17 12:03:02 +03:00
Mihai Bazon
07f1d56f69 more smallish optimizations 2012-09-17 11:50:35 +03:00
Mihai Bazon
5e60a60b3b try negating AST_Binary 2012-09-17 11:16:44 +03:00
Mihai Bazon
5d781ec6f8 some cleanup 2012-09-16 18:10:54 +03:00
Mihai Bazon
0f418d654e more sequencesizing (WIP) 2012-09-16 16:29:17 +03:00
Mihai Bazon
21c34a1792 drop unused function 2012-09-16 15:46:47 +03:00
Mihai Bazon
7b6a402916 rewrite handle_if_return 
optimizations of if/return/continue seem to be even better now
 2012-09-16 15:46:20 +03:00
Mihai Bazon
397bf56d25 other small optimization: 
if (foo) continue;
...body...

==>

if (!foo) { ...body ... }

Only when the parent block is the target loop of the `continue` statement.
 2012-09-15 16:10:35 +03:00
Mihai Bazon
86c14d0988 join_vars: 
var XXX;
for (var YYY; ...)

==>

for (var XXX,YYY; ...)
 2012-09-15 10:54:59 +03:00
Mihai Bazon
43fd45154b compress typeof x == "undefined" to x === undefined, which further gets 
shortened to x === void 0 (or x === [][0] in unsafe mode)
 2012-09-14 19:56:59 +03:00
Mihai Bazon
50d1670e42 minor 
when unsafe, compress undefined as [][0]
 2012-09-14 19:04:18 +03:00
Mihai Bazon
5e83e7ec17 adding an imaginary "return undefined" can sometimes help 
function f() {
  if (foo) return x();
  if (!bar) return y();
}

==>

function f() {
  return foo ? x() : bar ? void 0 : y();
}
 2012-09-14 16:26:30 +03:00
Mihai Bazon
924aa58060 more optimizations that v1 does and some cleanups 
- a = a + x ==> a+=x
- joining consecutive var statements (hoisting is not always desirable)
- x == false ==> x == 0, x != true ==> x != 1
- x, x ==> x; x = exp(), x ==> x = exp()
- discarding useless break-s
 2012-09-14 15:36:38 +03:00
Mihai Bazon
d72c1d1293 few more optimizations: 
- do multiple passes in tighten_body if it was changed
- transform if (foo) return x; return y; ==> return foo?x:y
- don't optimize !0 as true (use best_of after evaluation of constant expr)

With hoist_vars off we now beat UglifyJS v1 on jQuery-1.8.1
 2012-09-13 15:20:57 +03:00
Mihai Bazon
f5027ec1fc minor 2012-09-12 16:29:20 +03:00
Mihai Bazon
a132841fb9 more AST_If optimizations 2012-09-12 16:10:03 +03:00
Mihai Bazon
2b1e4628e0 side effect fixes and small optimization for gzip 
prefer to always use > and >= operators (idea from Closure)
 2012-09-12 13:41:46 +03:00
Mihai Bazon
2b4093ba83 fixed run-tests and an issue about reversing the condition in AST_If 2012-09-12 13:00:13 +03:00
Mihai Bazon
9a629abe00 minor 2012-09-11 18:37:08 +03:00
Mihai Bazon
da407d46c6 checkpoint 
- discard statements with no side effects (unsafe? could be)
- safer hoist_vars (needs some revamping of scope/mangling)
 2012-09-11 13:15:55 +03:00
Mihai Bazon
1579c0fb97 hoist_vars is pretty bad, it seems. cancelled it for now. 2012-09-10 22:40:18 +03:00
Mihai Bazon
a41e6cfabb more progress on the compressor (WIP) 2012-09-10 16:37:05 +03:00
Mihai Bazon
1c8ba35844 minor 2012-09-08 22:51:59 +03:00
Mihai Bazon
048d6906ae fix bug (forgot arg name) 2012-09-07 16:02:08 +03:00
Mihai Bazon
919b2733ab always keep declarations found in unreachable code 
a few more tests and some cleanups.
 2012-09-07 15:18:32 +03:00
Mihai Bazon
b77574ea1c fixed tests (need to drop the toplevel block in "expected" if it's a single statement) 2012-09-07 11:22:01 +03:00
Mihai Bazon
9bb1a84d6b don't duplicate argument names 2012-09-05 18:19:30 +03:00
Mihai Bazon
0503513dcc support for hoisting declarations 
and finally it seems we beat v1 in terms of compression
 2012-09-05 13:43:34 +03:00
Mihai Bazon
8633b0073f cleaned up usage of AST_BlockStatement 
The following nodes were instances of AST_BlockStatement: AST_Scope,
AST_SwitchBlock, AST_SwitchBranch.  Also, AST_Try, AST_Catch, AST_Finally
were having a body instanceof AST_BlockStatement.

Overloading the meaning of AST_BlockStatement this way turned out to be a
mess; we now have an AST_Block class that is the base class for things
having a block of statements (might or might not be bracketed).  The
`this.body` of AST_Scope, AST_Try, AST_Catch, AST_Finally is now an array of
statements (as they inherit from AST_Block).

Avoiding calling superclass's _walk function in walkers (turns out we walked
a node multiple times).
 2012-09-05 11:39:43 +03:00
Mihai Bazon
1b5183dd5e checkpoint 2012-09-04 15:36:14 +03:00
Mihai Bazon
376667a818 more fiddling with boolean expressions, etc. 
optimize away while(false), and transform while(true) ==> for(;;).

UNSAFE:

some expressions are optimized away when we're in boolean context and can
determine that the value will always be true or false.  For example:

    x() || true ==> always `true` in boolean context
    x() && false ==> always `false` in boolean context

It's not technically correct to drop these expressions since we drop the
function call too (that might have side effects); on the other hand, I can't
see any legitimate use for such expressions and they might simply indicate a
bug (we do warn about it).
 2012-09-04 13:20:28 +03:00
Mihai Bazon
86cfb5be86 boolean and if/exit optimizations 2012-09-03 23:49:57 +03:00
Mihai Bazon
e5f1cec6aa minor 2012-09-03 23:25:30 +03:00
Mihai Bazon
37eecc16a4 more optimizations for ifs/conditionals 
(XXX: should add tests before anything else)
 2012-09-03 19:38:45 +03:00
Mihai Bazon
f03138daa8 resolve constant expressions 2012-09-03 15:47:15 +03:00
Mihai Bazon
6d0db4ce14 an AST_If is too a StatementWithBody 2012-09-03 12:11:44 +03:00
Mihai Bazon
d7c1dc6c05 a LabeledStatement should be in fact a StatementWithBody 
This fixes output for:

    if (foo) {
        moo: if (bar) {
            break moo;
        }
    } else {
        baz();
    }

(the labeled statement must be outputted inside brackets)
 2012-09-03 12:05:10 +03:00
Mihai Bazon
58a3b5e93f update (c) years 2012-08-27 11:01:41 +03:00
Mihai Bazon
4437e7af19 fix compressing a,b; return c; into return a,b,c; 2012-08-27 11:00:22 +03:00
Mihai Bazon
95b18e54a4 added license 2012-08-22 21:28:59 +03:00
Mihai Bazon
159a6f048c wrote more of the compressor and added some tests 2012-08-22 15:21:58 +03:00
Mihai Bazon
1b839eb35b hint that brackets may be required in AST_BlockStatement 2012-08-21 19:16:05 +03:00
Mihai Bazon
ffe58a9961 cleaned up some mess and started the actual compressor 2012-08-21 16:14:43 +03:00